837068 - marionette runtests.py not working with "--profile" option

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Olivier Morandi]

Executing Firefox marionette tests (from mozilla-central/testing/marionette/client/marionette)

python runtests.py --binary=/path/to/firefox-bin --profile=/path/to/custom-profile tests

produces the following exception:

Traceback (most recent call last):
  File "runtests.py", line 716, in <module>
    cli()
  File "runtests.py", line 711, in cli
    runner = startTestRunner(runner_class, options, tests)
  File "runtests.py", line 706, in startTestRunner
    runner.run_tests(tests, testtype=options.type)
  File "runtests.py", line 349, in run_tests
    self.run_test(test, testtype)
  File "runtests.py", line 380, in run_test
    self.start_marionette()
  File "runtests.py", line 275, in start_marionette
    baseurl=self.baseurl)
  File "/Users/olivier/Code/mozilla/marionette/marionette/marionette.py", line 120, in __init__
    self.instance.start()
  File "/Users/olivier/Code/mozilla/marionette/marionette/geckoinstance.py", line 28, in start
    self.runner = Runner.create(binary=self.bin, profile_args=profile, cmdargs=['-no-remote'])
  File "/usr/local/Cellar/python/2.7.2/lib/python2.7/site-packages/mozrunner-5.2-py2.7.egg/mozrunner/runner.py", line 69, in create
    profile = cls.profile_class(**(profile_args or {}))
TypeError: type object argument after ** must be a mapping, not str

Comment 1

[Olivier Morandi]

Attachment: Fix for profile argument in geckoinstance.py

Comment 2

[David Burns :automatedtester]

Comment on attachment 708993 [details] [diff] [review]
Fix for profile argument in geckoinstance.py

Sorry for taking so long with this. This change looks good.

Can you land this or would you like me to?

Comment 3

[Olivier Morandi]

Thanks for the review. Could you help me with the process of getting this into the tree?

Comment 4

[David Burns :automatedtester]

Landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/c55ce1a65e1d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c55ce1a65e1d

Comment 6

[Malini Das [:mdas] - Away, not checking bugmail]

https://hg.mozilla.org/releases/mozilla-b2g18/pushloghtml?changeset=71f7f42dee13

Comment 7

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/b98569c7a233