marionette runtests.py not working with "--profile" option

RESOLVED FIXED in Firefox 22

Status

Testing
Marionette
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Olivier Morandi, Assigned: Olivier Morandi)

Tracking

21 Branch
mozilla22
Points:
---

Firefox Tracking Flags

(firefox22 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Executing Firefox marionette tests (from mozilla-central/testing/marionette/client/marionette)

python runtests.py --binary=/path/to/firefox-bin --profile=/path/to/custom-profile tests

produces the following exception:

Traceback (most recent call last):
  File "runtests.py", line 716, in <module>
    cli()
  File "runtests.py", line 711, in cli
    runner = startTestRunner(runner_class, options, tests)
  File "runtests.py", line 706, in startTestRunner
    runner.run_tests(tests, testtype=options.type)
  File "runtests.py", line 349, in run_tests
    self.run_test(test, testtype)
  File "runtests.py", line 380, in run_test
    self.start_marionette()
  File "runtests.py", line 275, in start_marionette
    baseurl=self.baseurl)
  File "/Users/olivier/Code/mozilla/marionette/marionette/marionette.py", line 120, in __init__
    self.instance.start()
  File "/Users/olivier/Code/mozilla/marionette/marionette/geckoinstance.py", line 28, in start
    self.runner = Runner.create(binary=self.bin, profile_args=profile, cmdargs=['-no-remote'])
  File "/usr/local/Cellar/python/2.7.2/lib/python2.7/site-packages/mozrunner-5.2-py2.7.egg/mozrunner/runner.py", line 69, in create
    profile = cls.profile_class(**(profile_args or {}))
TypeError: type object argument after ** must be a mapping, not str
(Assignee)

Comment 1

5 years ago
Created attachment 708993 [details] [diff] [review]
Fix for profile argument in geckoinstance.py
Attachment #708993 - Flags: review?(dburns)
Comment on attachment 708993 [details] [diff] [review]
Fix for profile argument in geckoinstance.py

Sorry for taking so long with this. This change looks good.

Can you land this or would you like me to?
Attachment #708993 - Flags: review?(dburns) → review+
(Assignee)

Comment 3

5 years ago
Thanks for the review. Could you help me with the process of getting this into the tree?
Landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/c55ce1a65e1d
https://hg.mozilla.org/mozilla-central/rev/c55ce1a65e1d
Assignee: nobody → olivier.morandi
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
https://hg.mozilla.org/releases/mozilla-b2g18/pushloghtml?changeset=71f7f42dee13
status-b2g18: --- → fixed
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/b98569c7a233
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: --- → fixed
status-firefox22: --- → fixed
You need to log in before you can comment on or make changes to this bug.