837142 - Regression: about:home promo banner swaps on device rotation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Swaps between Sync and Marketplace on rotation

--
Nightly (02/01)
Samsung Galaxy Nexus (Android 4.2)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Ian - Looks like Wes' refactor of the Promo code made it display a potentially new promo anytime About Home needs to repaint. Is this worth keeping? Or do we want to "fix" the promo during the lifetime of the application?

Comment 2

[Ian Barlow (:ibarlow)]

I think at the very least we would want to fix it to a single promo for any current instance of about:home, including if it gets rotated.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

AboutHomePromoBox is recreated on each rotation, so the promo is randomized on each rotation. This patch uses a static index to remember the initial randomized index used to pick a promo type.

This fixes the problem, but still allows the promo to randomize on each new app session (quit/restart).

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0bd553a7032f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0bd553a7032f

Comment 6

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 21.0a1 (2013-02-17)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.1