Closed Bug 837142 Opened 7 years ago Closed 7 years ago

Regression: about:home promo banner swaps on device rotation

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 21
Tracking Status
firefox21 --- verified

People

(Reporter: aaronmt, Assigned: mfinkle)

References

Details

(Keywords: regression, reproducible)

Attachments

(1 file)

Swaps between Sync and Marketplace on rotation

--
Nightly (02/01)
Samsung Galaxy Nexus (Android 4.2)
Version: Firefox 19 → Trunk
Assignee: nobody → mark.finkle
Ian - Looks like Wes' refactor of the Promo code made it display a potentially new promo anytime About Home needs to repaint. Is this worth keeping? Or do we want to "fix" the promo during the lifetime of the application?
Flags: needinfo?(ibarlow)
I think at the very least we would want to fix it to a single promo for any current instance of about:home, including if it gets rotated.
Flags: needinfo?(ibarlow)
Attached patch patchSplinter Review
AboutHomePromoBox is recreated on each rotation, so the promo is randomized on each rotation. This patch uses a static index to remember the initial randomized index used to pick a promo type.

This fixes the problem, but still allows the promo to randomize on each new app session (quit/restart).
Attachment #709915 - Flags: review?(wjohnston)
Attachment #709915 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/0bd553a7032f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Depends on: 838745
Verified fixed on:
-build: Firefox for Android 21.0a1 (2013-02-17)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.1
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.