Closed Bug 837142 Opened 8 years ago Closed 8 years ago
Regression: about:home promo banner swaps on device rotation
Swaps between Sync and Marketplace on rotation -- Nightly (02/01) Samsung Galaxy Nexus (Android 4.2)
Assignee: nobody → mark.finkle
Ian - Looks like Wes' refactor of the Promo code made it display a potentially new promo anytime About Home needs to repaint. Is this worth keeping? Or do we want to "fix" the promo during the lifetime of the application?
I think at the very least we would want to fix it to a single promo for any current instance of about:home, including if it gets rotated.
AboutHomePromoBox is recreated on each rotation, so the promo is randomized on each rotation. This patch uses a static index to remember the initial randomized index used to pick a promo type. This fixes the problem, but still allows the promo to randomize on each new app session (quit/restart).
Attachment #709915 - Flags: review?(wjohnston)
Attachment #709915 - Flags: review?(wjohnston) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Verified fixed on: -build: Firefox for Android 21.0a1 (2013-02-17) -device: Samsung Galaxy Nexus -OS: Android 4.2.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.