837212 - Convert toolkit/modules/tests/browser_TelemetryTimestamps.js to xpcshell

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[:Irving Reid (No longer working on Firefox)]

Attachment: WIP: Convert browser_TelemetryTimestamps.js tests to xpcshell

This test gets very little benefit from being a browser chrome test; it should switch to xpcshell. Work in progress attached, but waiting for bug 809920 to sort out Services.appinfo issues under xpcshell.

Comment 1

[:Irving Reid (No longer working on Firefox)]

Attachment: Convert browser_TelemetryTimestamps.js tests to xpcshell

Changing to xpcshell loses one test case, because nothing in the xpcshell runtime adds any startup timestamps directly to the telemetry ping.

Comment 2

[:Irving Reid (No longer working on Firefox)]

Note that this patch requires the patch from bug 810146 to be applied first.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 710284 [details] [diff] [review]
Convert browser_TelemetryTimestamps.js tests to xpcshell

Changes to the test look fine. The patch has a copy instead of a rename here:

> diff --git a/toolkit/modules/tests/browser_TelemetryTimestamps.js b/toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js
> copy from toolkit/modules/tests/browser_TelemetryTimestamps.js
> copy to toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js

so please fix that. Feel free to do that together with bug 810146 if you want to do everything in one step.

It would also be nice if you add a brief comment explaining why the appinfo workaround is necessary so that someone else writing a similar test in the future can understand it more easily.

Comment 4

[:Irving Reid (No longer working on Firefox)]

Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/c1a747d02e87

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c1a747d02e87