Closed Bug 837212 Opened 8 years ago Closed 8 years ago
_Telemetry Timestamps .js to xpcshell
This test gets very little benefit from being a browser chrome test; it should switch to xpcshell. Work in progress attached, but waiting for bug 809920 to sort out Services.appinfo issues under xpcshell.
Changing to xpcshell loses one test case, because nothing in the xpcshell runtime adds any startup timestamps directly to the telemetry ping.
Note that this patch requires the patch from bug 810146 to be applied first.
Attachment #710284 - Flags: review?(gavin.sharp) → review?(felipc)
Comment on attachment 710284 [details] [diff] [review] Convert browser_TelemetryTimestamps.js tests to xpcshell Changes to the test look fine. The patch has a copy instead of a rename here: > diff --git a/toolkit/modules/tests/browser_TelemetryTimestamps.js b/toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js > copy from toolkit/modules/tests/browser_TelemetryTimestamps.js > copy to toolkit/modules/tests/xpcshell/test_TelemetryTimestamps.js so please fix that. Feel free to do that together with bug 810146 if you want to do everything in one step. It would also be nice if you add a brief comment explaining why the appinfo workaround is necessary so that someone else writing a similar test in the future can understand it more easily.
Attachment #710284 - Flags: review?(felipc) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.