837213 - Turn on SH_CLAMP_INDIRECT_ARRAY_BOUNDS everywhere

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 827106 to work around a driver bug on Linux we're turning on SH_CLAMP_INDIRECT_ARRAY_BOUNDS on non-Windows platforms. We'd like to turn it on everywhere but for that we need ANGLE r1719, 1733, 1734. So let's do another ANGLE update first. Once we have it on Linux (bug 827106) the rest is not an emergency.

Comment 1

[Alex Keybl [:akeybl]]

Dan - why should this go into FF22 specifically? Not clear what the motivation is to track.

Comment 2

[Daniel Veditz [:dveditz]]

We want this to protect against any other driver issues like bug 827106 that might be lurking out there. When I set the flag mozilla-central was Fx22 so I picked that one; if you want to bump it to Fx23 I guess that's OK since we don't have positive knowledge of such windows driver bugs. The ANGLE folks added the feature though: they at least worried about the possibility of such bugs and may have had some reported to them.

Comment 3

[Alex Keybl [:akeybl]]

Benoit - can you help get this landed on FF23 while it's still on m-c?

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Sure, as soon as bug 837214 lands. Putting a needinfo on myself so I don't forget (the ASSIGNEE field doesn't work that well for me, I have too many open bugs).

Comment 5

[Kelsey Gilbert [:jgilbert]]

I already have the patch for this, I'm just waiting on more favorable results from Try for the main ANGLE update.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: patch: Post r2042 update, turn on clamping on windows

Comment 7

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8eefefa4e681

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8eefefa4e681

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

can we get a beta uplift nomination here?  what's the risk of taking this in beta?

Comment 10

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to [e-mail] [:lsblakk] from comment #9)
> can we get a beta uplift nomination here?  what's the risk of taking this in
> beta?

I would imagine this would be a risky move, what with the new version of ANGLE being a prerequisite.

Comment 11

[Kelsey Gilbert [:jgilbert]]

Yeah, this is not really necessary to uplift.