YouTube video's redirect on play; broken on tablets

VERIFIED FIXED in Firefox 21

Status

()

defect
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: aaronmt, Assigned: mfinkle)

Tracking

Trunk
Firefox 21
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox21 verified)

Details

()

Attachments

(1 attachment)

Reporter

Updated

7 years ago
Posted patch patchSplinter Review
Proposed fix:
* compile the regex ahead of time
* look for a phone UA and if we don't find one, assume tablet UA, and change the UA to phone UA

Testing patch...
Assignee: nobody → mark.finkle
Attachment #709176 - Flags: review?(bnicholson)
Comment on attachment 709176 [details] [diff] [review]
patch

r+ on browser.js parts
Attachment #709176 - Flags: review?(bnicholson) → review+
Tests show that this patch correctly opens the YouTube player and plays the video.
Reporter

Comment 5

7 years ago
So is the hack still needed or what?
https://hg.mozilla.org/mozilla-central/rev/971141fe081e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
(In reply to Aaron Train [:aaronmt] from comment #5)
> So is the hack still needed or what?

The hack is still needed. Without the hack, Firefox on tablets will fail to open videos in the Youtube player.
Reporter

Comment 8

6 years ago
Never want to see this bug again!
Status: RESOLVED → VERIFIED
aaronmt: your wish may not be granted... Does this need backing out as a consequence of the backing out of the Tablet change? mfinkle?

Gerv
(In reply to Gervase Markham [:gerv] from comment #9)
> aaronmt: your wish may not be granted... Does this need backing out as a
> consequence of the backing out of the Tablet change? mfinkle?
> 
> Gerv

Nope. I made the code depend on "Mobile" instead of "Tablet". We are still working fine.
You need to log in before you can comment on or make changes to this bug.