837215 - YouTube video's redirect on play; broken on tablets

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This is a regression from bug 829596

Our hack is broken!

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#2636

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Proposed fix:
* compile the regex ahead of time
* look for a phone UA and if we don't find one, assume tablet UA, and change the UA to phone UA

Testing patch...

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 709176 [details] [diff] [review]
patch

r+ on browser.js parts

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Tests show that this patch correctly opens the YouTube player and plays the video.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/971141fe081e

Comment 5

[Aaron Train [:aaronmt]]

So is the hack still needed or what?

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/971141fe081e

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #5)
> So is the hack still needed or what?

The hack is still needed. Without the hack, Firefox on tablets will fail to open videos in the Youtube player.

Comment 8

[Aaron Train [:aaronmt]]

Never want to see this bug again!

Comment 9

[Gervase Markham [:gerv]]

aaronmt: your wish may not be granted... Does this need backing out as a consequence of the backing out of the Tablet change? mfinkle?

Gerv

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Gervase Markham [:gerv] from comment #9)
> aaronmt: your wish may not be granted... Does this need backing out as a
> consequence of the backing out of the Tablet change? mfinkle?
> 
> Gerv

Nope. I made the code depend on "Mobile" instead of "Tablet". We are still working fine.