Closed Bug 837215 Opened 7 years ago Closed 7 years ago
Tube video's redirect on play; broken on tablets
This is a regression from bug 829596 Our hack is broken! http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#2636
Proposed fix: * compile the regex ahead of time * look for a phone UA and if we don't find one, assume tablet UA, and change the UA to phone UA Testing patch...
Assignee: nobody → mark.finkle
Attachment #709176 - Flags: review?(bnicholson)
Comment on attachment 709176 [details] [diff] [review] patch r+ on browser.js parts
Attachment #709176 - Flags: review?(bnicholson) → review+
Tests show that this patch correctly opens the YouTube player and plays the video.
So is the hack still needed or what?
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
(In reply to Aaron Train [:aaronmt] from comment #5) > So is the hack still needed or what? The hack is still needed. Without the hack, Firefox on tablets will fail to open videos in the Youtube player.
aaronmt: your wish may not be granted... Does this need backing out as a consequence of the backing out of the Tablet change? mfinkle? Gerv
(In reply to Gervase Markham [:gerv] from comment #9) > aaronmt: your wish may not be granted... Does this need backing out as a > consequence of the backing out of the Tablet change? mfinkle? > > Gerv Nope. I made the code depend on "Mobile" instead of "Tablet". We are still working fine.
You need to log in before you can comment on or make changes to this bug.