Closed Bug 837215 Opened 7 years ago Closed 7 years ago

YouTube video's redirect on play; broken on tablets

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 21
Tracking Status
firefox21 --- verified

People

(Reporter: aaronmt, Assigned: mfinkle)

References

()

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Proposed fix:
* compile the regex ahead of time
* look for a phone UA and if we don't find one, assume tablet UA, and change the UA to phone UA

Testing patch...
Assignee: nobody → mark.finkle
Attachment #709176 - Flags: review?(bnicholson)
Comment on attachment 709176 [details] [diff] [review]
patch

r+ on browser.js parts
Attachment #709176 - Flags: review?(bnicholson) → review+
Tests show that this patch correctly opens the YouTube player and plays the video.
So is the hack still needed or what?
https://hg.mozilla.org/mozilla-central/rev/971141fe081e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
(In reply to Aaron Train [:aaronmt] from comment #5)
> So is the hack still needed or what?

The hack is still needed. Without the hack, Firefox on tablets will fail to open videos in the Youtube player.
Never want to see this bug again!
Status: RESOLVED → VERIFIED
aaronmt: your wish may not be granted... Does this need backing out as a consequence of the backing out of the Tablet change? mfinkle?

Gerv
(In reply to Gervase Markham [:gerv] from comment #9)
> aaronmt: your wish may not be granted... Does this need backing out as a
> consequence of the backing out of the Tablet change? mfinkle?
> 
> Gerv

Nope. I made the code depend on "Mobile" instead of "Tablet". We are still working fine.
You need to log in before you can comment on or make changes to this bug.