Closed
Bug 837215
Opened 10 years ago
Closed 10 years ago
YouTube video's redirect on play; broken on tablets
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox21 verified)
VERIFIED
FIXED
Firefox 21
Tracking | Status | |
---|---|---|
firefox21 | --- | verified |
People
(Reporter: aaronmt, Assigned: mfinkle)
References
()
Details
Attachments
(1 file)
5.61 KB,
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
This is a regression from bug 829596 Our hack is broken! http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#2636
Reporter | ||
Updated•10 years ago
|
status-firefox21:
--- → affected
Assignee | ||
Comment 1•10 years ago
|
||
Proposed fix: * compile the regex ahead of time * look for a phone UA and if we don't find one, assume tablet UA, and change the UA to phone UA Testing patch...
Assignee: nobody → mark.finkle
Attachment #709176 -
Flags: review?(bnicholson)
Comment 2•10 years ago
|
||
Comment on attachment 709176 [details] [diff] [review] patch r+ on browser.js parts
Attachment #709176 -
Flags: review?(bnicholson) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Tests show that this patch correctly opens the YouTube player and plays the video.
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/971141fe081e
Reporter | ||
Comment 5•10 years ago
|
||
So is the hack still needed or what?
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/971141fe081e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #5) > So is the hack still needed or what? The hack is still needed. Without the hack, Firefox on tablets will fail to open videos in the Youtube player.
Comment 9•10 years ago
|
||
aaronmt: your wish may not be granted... Does this need backing out as a consequence of the backing out of the Tablet change? mfinkle? Gerv
Assignee | ||
Comment 10•10 years ago
|
||
(In reply to Gervase Markham [:gerv] from comment #9) > aaronmt: your wish may not be granted... Does this need backing out as a > consequence of the backing out of the Tablet change? mfinkle? > > Gerv Nope. I made the code depend on "Mobile" instead of "Tablet". We are still working fine.
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•