Closed Bug 837232 Opened 12 years ago Closed 11 years ago

Intermittent test_privatemode_perwindowpb.xul | application timed out after 330 seconds with no output

Categories

(Core Graveyard :: Plug-ins, defect, P3)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86_64
macOS
Type:
defect

Tracking

(firefox24 fixed, firefox25 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla25
Tracking Flags:
Tracking Status
firefox24 --- fixed
firefox25 --- fixed

People

(Reporter: philor, Assigned: brennan.brisad)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Use whenDelayedStartupFinished instead of waiting for 'load', v2
2.87 KB, patch
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=19357225&tree=Mozilla-Inbound Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test mochitest-other on 2013-02-01 07:35:19 PST for push 5527dd4bfcbf slave: talos-r4-snow-035 4238 INFO TEST-START | chrome://mochitests/content/chrome/dom/plugins/test/test_privatemode_perwindowpb.xul NPP_Destroy ++DOMWINDOW == 25 (0x14eee1998) [serial = 1046] [outer = 0x12b632438] WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 2985 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 324 For application/x-test found plugin Test.plugin For application/x-test found plugin Test.plugin 4239 INFO TEST-PASS | chrome://mochitests/content/chrome/dom/plugins/test/test_privatemode_perwindowpb.xul | Exception thrown getting private mode state. 4240 INFO TEST-PASS | chrome://mochitests/content/chrome/dom/plugins/test/test_privatemode_perwindowpb.xul | Browser returned incorrect private mode state. 4241 INFO TEST-PASS | chrome://mochitests/content/chrome/dom/plugins/test/test_privatemode_perwindowpb.xul | Browser returned incorrect private mode state. WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file ../../../../content/base/src/ThirdPartyUtil.cpp, line 271 WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file ../../../../content/base/src/ThirdPartyUtil.cpp, line 271 4242 INFO TEST-PASS | chrome://mochitests/content/chrome/dom/plugins/test/test_privatemode_perwindowpb.xul | Cookie was set and retrieved correctly in public mode. ++DOCSHELL 0x15921fd50 == 9 [id = 238] ++DOMWINDOW == 26 (0x159680978) [serial = 1047] [outer = 0x0] ++DOMWINDOW == 27 (0x158788818) [serial = 1048] [outer = 0x159680978] ++DOCSHELL 0x14d0ef260 == 10 [id = 239] ++DOMWINDOW == 28 (0x14eec76d8) [serial = 1049] [outer = 0x0] ++DOCSHELL 0x14cbbf2e0 == 11 [id = 240] ++DOMWINDOW == 29 (0x14eee9fc8) [serial = 1050] [outer = 0x0] ++DOCSHELL 0x14d450ee0 == 12 [id = 241] ++DOMWINDOW == 30 (0x159286b58) [serial = 1051] [outer = 0x0] ++DOMWINDOW == 31 (0x12f2eae88) [serial = 1052] [outer = 0x159286b58] WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv) && subjPrincipal) failed: file ../../../docshell/base/nsDocShell.cpp, line 8335 WARNING: Subdocument container has no frame: file ../../../layout/base/nsDocumentViewer.cpp, line 2393 ++DOMWINDOW == 32 (0x12f496de8) [serial = 1053] [outer = 0x14eec76d8] WARNING: Subdocument container has no frame: file ../../../layout/base/nsDocumentViewer.cpp, line 2393 ++DOMWINDOW == 33 (0x108f425a8) [serial = 1054] [outer = 0x14eee9fc8] ++DOMWINDOW == 34 (0x14d0beaf8) [serial = 1055] [outer = 0x159286b58] WARNING: NS_ENSURE_TRUE(mTextInputHandler) failed: file ../../../widget/cocoa/nsChildView.mm, line 3938 WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 265 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/plugins/test/test_privatemode_perwindowpb.xul | application timed out after 330 seconds with no output (screenshot) Can't trigger Breakpad, just killing process INFO | automation.py | Application ran for: 0:11:11.894179
This is almost certainly the same as bug 837038 and may be related to bug 836829... it's likely that these are all "tests which run some time after a hang test", which in this case is test_hang_submit.xul and the other case is test_hanging.html
Priority: -- → P3
Since a new browser window is opened here, I added a call to whenDelayedStartupFinished, which should prevent a race condition that could cause this bug. I also removed the event listener registration for 'load', as I guess it is not needed if we wait for delayed startup. Or are the events independent? I don't know how to test this properly since it is an intermittent bug, but I ran it once on try and that didn't cause any problems. I also couldn't figure out how to resue any existing whenDelayedStartupFinished method, so I simply dumped it here just for trying. I guess it should be moved to some common place?
Attachment #771645 - Flags: feedback?(gavin.sharp)
(In reply to Michael Brennan from comment #72) > Since a new browser window is opened here, I added a call to > whenDelayedStartupFinished, which should prevent a race condition that could > cause this bug. I also removed the event listener registration for 'load', > as I guess it is not needed if we wait for delayed startup. Or are the > events independent? delayedStartup is triggered from the window's load event handler, so it is indeed unnecessary to watch for both. browser-delayed-startup-finished is not fired by SeaMonkey or other apps, so this may cause test failures for them. > I also couldn't figure out how to resue any existing > whenDelayedStartupFinished method, so I simply dumped it here just for > trying. I guess it should be moved to some common place? Maybe, but just copying is fine for now, I think.
Comment on attachment 771645 [details] [diff] [review] Use whenDelayedStartupFinished instead of waiting for 'load' >diff --git a/dom/plugins/test/mochitest/test_privatemode_perwindowpb.xul b/dom/plugins/test/mochitest/test_privatemode_perwindowpb.xul >+Components.utils.import("resource://gre/modules/XPCOMUtils.jsm"); >+ >+XPCOMUtils.defineLazyModuleGetter(this, "Services", >+ "resource://gre/modules/Services.jsm"); Why lazy getter? Services.jsm is so widely used that it's garanteed to already be loaded, so just import it unconditionally as with XPCOMUtils.
Attachment #771645 - Flags: feedback?(gavin.sharp) → review+
Oh, yeah I didn't give a second thought about that one since I assumed this weren't the place to put the function definition. I'll change it.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/94c61aeeebf9
Assignee: nobody → brennan.brisad
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: