837255 - [B2G] [Leo][SMS]Sending email to contact shows display name in email as "[e-mail] <[e-mail]>"

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Add a contact "John Smith" with address [e-mail]
 (2) Open contact in details view
 (3) Tap to send an email

I expect the "To:" line to show up as "John Smith <[e-mail]>", but instead it shows up as "[e-mail] <[e-mail]>".

Not sure which app is at fault here.

b? -> radar

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

email is if I'm reading the code right :
https://github.com/mozilla-b2g/gaia/blob/v1.0.0/apps/email/js/compose-cards.js#L106

Comment 2

[Steve Chung [:steveck]]

The easier solution for this issue is passing the name from contact, and email can receive both email address and name. Another solution is implementing the contact management(helper function set for contact related stuff like auto-complete) in email. I think it's necessary to have this feature eventually, but we can apply the former solution quickly or just implement part of the contact management if this issue is urgent. Thanks.

Comment 3

[Alex Keybl [:akeybl]]

Not a blocker, but tracking - user is still able to email and shouldn't be confused by this. Mostly cosmetic.

Comment 4

[Alex Keybl [:akeybl]]

Steve - are you the right person to look into this for v1.x?

Comment 5

[Steve Chung [:steveck]]

I can take a look after finishing TEF_REQ UX issue, thanks.

Comment 6

[Steve Chung [:steveck]]

Er.. Sorry for flag reset

Comment 7

[alberto.pastor]

Steve, are you working on this? I can take it if needed.

Comment 8

[alberto.pastor]

Almost 10 days without news so I'm going to steal the bug :)

Comment 9

[alberto.pastor]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9356

Pointer to Github pull-request

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 740811 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9356

Rather than introducing an ad hoc e-mail address parser in the e-mail front-end, we should use the existing addressparser library, probably just in the back-end on the worker thread, but we could also do it in the back-end provided MailAPI on the main thread too.  I've filed bug 864990 for that.

Also, the e-mail address you are composing on the contacts side of the house is using obsolete syntax and could benefit from webspace.  See https://tools.ietf.org/html/rfc2822#section-3.4 for more details, but you'd basically want to put the name in quotes (and probably just strip any quote characters that exist inside the name string), have a space character after the quotes.

But we could also just avoid the need to pass everything through a mailto URI.  I'd have no problem if our "new" verb for { type: "mail" } took a dict like { to: [ { name, address } ], cc: [], bcc: [], subject: "" }, and it would save everyone a lot of hassle that doesn't need to speak 'mailto' because they are real web things.

Comment 11

[Andrew Sutherland [:asuth] (he/him)]

And s/webspace/whitespace.  The string you create right now will look like:
John Doe<[e-mail]>

It should looke like:
"John Doe" <[e-mail]>

Comment 12

[bov]

This issue tested on Leo 1.1 (Test Run Firefox OS 1.1.0 Full – Leo)
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e3f39363c54
Gaia: ea18de80fd04110756becaed214656642388401d
Platform Version: 18.0

STEPS:
1.Send a sms from "device A" (DUT) to "device B" that contains an email address (e.g.: "[e-mail]" which belongs to an existing contact (e.g.:"Lucy"), with two email address added
2.Open the SMS thread view in the device A (DUT)
3.Click on the email address ("[e-mail]")

EXPECTED RESULT:
Email app is launched with the contact name ("Lucy")charged in "to:" field
ACTUAL RESULT:
Email app is launched only with the email address ("[e-mail]")charged in "to:" field

Link to failed test case: 
https://moztrap.mozilla.org/manage/case/7160/

Comment 13

[bov]

Link to failed test case: 
https://moztrap.mozilla.org/manage/case/7161/
https://moztrap.mozilla.org/manage/case/7162/
https://moztrap.mozilla.org/manage/case/7163/

Comment 14

[Andrew Sutherland [:asuth] (he/him)]

The e-mail app is now a lot more aggressive about mapping e-mail addresses to contacts (in the reader) and keeping them up to date, and we have been normalizing our 'peep bubble' representation in the UI.  As such, it might make sense to kick the bug over to just being the e-mail app's problem and having the contacts app just provide the e-mail address since we'll resolve the e-mail address to a contact anyways.  I filed bug 883008 about fixing that bit of e-mail.

Comment 15

[Jeni]

Issue repros on 
Leo Build ID: 20130625070217
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1

When sending a email to a address that is already in your contacts it shows as the email address and not the users name.

Comment 16

[bov]

This issue tested on Leo 1.1 (Test Run Firefox OS 1.1.0 Full – Leo Run 4)
Gecko a378807ff04076c20f08b0102286b9eb2d08d60a
Gaia 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1

STEPS:
1.Send a sms from "device A" (DUT) to "device B" that contains an email address (e.g.: "[e-mail]" which belongs to an existing contact (e.g.:"Lucy"), with two email address added
2.Open the SMS thread view in the device A (DUT)
3.Click on the email address ("[e-mail]")

EXPECTED RESULT:
Email app is launched with the contact name ("Lucy")charged in "to:" field
ACTUAL RESULT:
Email app is launched only with the email address ("[e-mail]")charged in "to:" field

Link to failed test case: 
https://moztrap.mozilla.org/manage/case/7160/
https://moztrap.mozilla.org/manage/case/7161/
https://moztrap.mozilla.org/manage/case/7162/
https://moztrap.mozilla.org/manage/case/7163/

Comment 17

[BMO Automation]

Firefox OS is not being worked on