Enable Ubuntu tests slaves on cedar b2g

RESOLVED FIXED

Status

Release Engineering
General Automation
P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(10 attachments)

Comment hidden (empty)
Reftests (and I think crashtests?) will need to stay on physical machines as they need hardware acceleration, everything else can be moved over.
(Assignee)

Comment 2

5 years ago
Created attachment 709401 [details] [diff] [review]
puppet-manifests
Attachment #709401 - Flags: review?(catlee)
(Assignee)

Comment 3

5 years ago
Created attachment 709403 [details] [diff] [review]
configs

It passes test_masters.sh and generates a sane diff. Still need to look at the dump_master.py output.
(Assignee)

Comment 4

5 years ago
Comment on attachment 709403 [details] [diff] [review]
configs

Review of attachment 709403 [details] [diff] [review]:
-----------------------------------------------------------------

dump_masters.sh shows a sane output as well.

::: mozilla-tests/b2g_config.py
@@ +382,5 @@
>          },
> +        'ubuntu32-b2g': {
> +            'opt_unittest_suites': UNITTEST_SUITES['opt_unittest_suites'][:],
> +            'debug_unittest_suites': UNITTEST_SUITES['debug_unittest_suites'][:],
> +            'suite_config': {

This block is a copy of fedora-b2g block above

@@ +929,5 @@
> +# explicitly set slave platforms per branch
> +for branch in BRANCHES.keys():
> +    for platform in BRANCHES[branch]['platforms']:
> +        if 'slave_platforms' not in BRANCHES[branch]['platforms'][platform]:
> +            BRANCHES[branch]['platforms'][platform]['slave_platforms'] = PLATFORMS[platform]['slave_platforms']

If per branch slave_platform is not set, misc.py tries to use platform specific slave_platforms.

@@ +954,2 @@
>  
> +    for k, v in sorted(items.iteritems()):

copy/paste from config.py
Attachment #709403 - Flags: review?(catlee)
(Assignee)

Updated

5 years ago
Priority: -- → P3
(Assignee)

Updated

5 years ago
Priority: P3 → P2
(Assignee)

Comment 5

5 years ago
Created attachment 710205 [details] [diff] [review]
configs (no ubuntu32-b2g)

intediff is here: https://gist.github.com/rail/4715081
basically s/ubuntu32-b2g/ubuntu32/g
Attachment #709401 - Attachment is obsolete: true
Attachment #709403 - Attachment is obsolete: true
Attachment #709401 - Flags: review?(catlee)
Attachment #709403 - Flags: review?(catlee)
Attachment #710205 - Flags: review?(catlee)

Updated

5 years ago
Attachment #710205 - Flags: review?(catlee) → review+
(Assignee)

Comment 6

5 years ago
Comment on attachment 710205 [details] [diff] [review]
configs (no ubuntu32-b2g)

http://hg.mozilla.org/build/buildbot-configs/rev/91c4a7367f38
Attachment #710205 - Flags: checked-in+
(Assignee)

Comment 7

5 years ago
Comment on attachment 710205 [details] [diff] [review]
configs (no ubuntu32-b2g)

http://hg.mozilla.org/build/buildbot-configs/rev/e3241dfffca5

Hmm, for some reason it didn't pass test-masters.sh...
Attachment #710205 - Flags: checked-in+ → checked-in-
(Assignee)

Comment 8

5 years ago
It turns out that "-b2g" suffix is needed to generate unique builddirs:

ValueError: builder b2g_ics_armv7a_gecko_emulator_ubuntu32 cedar opt test mochitest-1 reuses builddir cedar_ubuntu32_test-mochitest-1
(Assignee)

Comment 9

5 years ago
Comment on attachment 709401 [details] [diff] [review]
puppet-manifests

Reincarnation in progress...
Attachment #709401 - Attachment is obsolete: false
Attachment #709401 - Flags: review?(catlee)
(Assignee)

Updated

5 years ago
Attachment #709403 - Attachment is obsolete: false
Attachment #709403 - Flags: review?(catlee)

Updated

5 years ago
Attachment #709401 - Flags: review?(catlee) → review+
Comment on attachment 709403 [details] [diff] [review]
configs

Review of attachment 709403 [details] [diff] [review]:
-----------------------------------------------------------------

booooo
Attachment #709403 - Flags: review?(catlee) → review+
(Assignee)

Comment 11

5 years ago
Comment on attachment 709401 [details] [diff] [review]
puppet-manifests

http://hg.mozilla.org/build/puppet-manifests/rev/fac2a07117d5
Attachment #709401 - Flags: checked-in+
(Assignee)

Comment 12

5 years ago
Comment on attachment 709403 [details] [diff] [review]
configs

http://hg.mozilla.org/build/buildbot-configs/rev/c8d9abc885ab
Attachment #709403 - Flags: checked-in+
(Assignee)

Comment 13

5 years ago
in production
(Assignee)

Comment 14

5 years ago
Created attachment 710674 [details] [diff] [review]
Rename builders

It turns out that "ubuntu" substring goes to Ubuntu platform on tbpl. It would be better to have more distinguishable name not containing the slave platform. The next patch will add another row to tbpl as well (B2G Arm (VM)).
Attachment #710674 - Flags: review?(catlee)
(Assignee)

Comment 15

5 years ago
Created attachment 710675 [details] [diff] [review]
TBPL changes
Attachment #710675 - Flags: review?(emorley)
Comment on attachment 710675 [details] [diff] [review]
TBPL changes

Presume at some point in the future when we're happy the VM runs are reliable and have switched most things over (other than those in comment 1), we can remove this special-case and just have everything on one row? 

(Similar to how both normal and AWS builds appear on the same style rows on TBPL currently - with the slave name still allowing one to distinguish if needed)
Attachment #710675 - Flags: review?(emorley) → review+
Blocks: 838594

Updated

5 years ago
Attachment #710674 - Flags: review?(catlee) → review+
(Assignee)

Comment 17

5 years ago
Comment on attachment 710674 [details] [diff] [review]
Rename builders

http://hg.mozilla.org/build/buildbot-configs/rev/4f0e15059ddd
Attachment #710674 - Flags: checked-in+
(Assignee)

Comment 18

5 years ago
Comment on attachment 710675 [details] [diff] [review]
TBPL changes

http://hg.mozilla.org/webtools/tbpl/rev/c256cae3f5ca
Attachment #710675 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Depends on: 838641
In production
I noticed that reftests are being run, these shouldn't be and are expected to fail. I don't know why everything else is failing.

We can either:
A) Try running them on the 64 bit pool, this is what I tested and it worked (need to install ia32-libs though)
B) Get a loaner 32 bit VM and try to debug the problems

Unfortunately I have no idea how hard either approach will be.
(Assignee)

Comment 21

5 years ago
I'm a little bit worried about A) approach because it may affect other tests, since we're going to change system libraries (well, add some).

Can we try B), maybe the fix is trivial? We can also try adding more CPU/memory to see if that's the problem.
Filed bug 840042 for access to a loaner VM
Created attachment 712925 [details] [diff] [review]
don't run reftests on ubuntu32-b2g in cedar

Due to graphics requirements we shouldn't be running reftests on a VM. This should disable them again on cedar.
Attachment #712925 - Flags: review?(rail)
(Assignee)

Updated

5 years ago
Depends on: 818968
(Assignee)

Comment 24

5 years ago
Comment on attachment 712925 [details] [diff] [review]
don't run reftests on ubuntu32-b2g in cedar

Sorry for the delay with review. Looks good to me. Thanks!
Attachment #712925 - Flags: review?(rail) → review+
Comment on attachment 712925 [details] [diff] [review]
don't run reftests on ubuntu32-b2g in cedar

http://hg.mozilla.org/build/buildbot-configs/rev/86e7ec905b68
Attachment #712925 - Flags: checked-in+
Comment on attachment 712925 [details] [diff] [review]
don't run reftests on ubuntu32-b2g in cedar

This patch is in production.
(Assignee)

Updated

5 years ago
Depends on: 843179
(Assignee)

Comment 27

5 years ago
Created attachment 716124 [details] [diff] [review]
[puppet] install ia32-libs

... if bug 837268 goes smoothly.
(Assignee)

Comment 28

5 years ago
Created attachment 716125 [details] [diff] [review]
puppet-manifests

ubuntu32-b2g will be removed once we switch.
Attachment #716125 - Flags: review?(catlee)
(Assignee)

Comment 29

5 years ago
Created attachment 716127 [details] [diff] [review]
configs
Attachment #716127 - Flags: review?(catlee)
(Assignee)

Updated

5 years ago
Attachment #716124 - Flags: review?(dustin)

Updated

5 years ago
Attachment #716125 - Flags: review?(catlee) → review+
Comment on attachment 716127 [details] [diff] [review]
configs

Review of attachment 716127 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/BuildSlaves.py.template
@@ +17,5 @@
>      "fedora-b2g": "pass",
>      "panda_android": "pass",
>      "b2g_panda": "pass",
>      "ubuntu32": "pass",
> +    "ubuntu64-b2g": "pass",

I was just thinking that a comment here or somewhere more appropriate about why we need these -b2g variants of the platforms would be great. I keep forgetting why we need them :)
Attachment #716127 - Flags: review?(catlee) → review+
Comment on attachment 716124 [details] [diff] [review]
[puppet] install ia32-libs

Can you add a comment as to why this is needed?  It's not clear to me from reading this bug.
Attachment #716124 - Flags: review?(dustin) → review+
(Assignee)

Comment 32

5 years ago
Comment on attachment 716125 [details] [diff] [review]
puppet-manifests

http://hg.mozilla.org/build/puppet-manifests/rev/99d975bc7697
Attachment #716125 - Flags: checked-in+
(Assignee)

Comment 33

5 years ago
Comment on attachment 716124 [details] [diff] [review]
[puppet] install ia32-libs

http://hg.mozilla.org/build/puppet/rev/63a5b3005adb
Attachment #716124 - Flags: checked-in+
(Assignee)

Comment 34

5 years ago
Created attachment 717168 [details] [diff] [review]
kill ubuntu32-b2g
Attachment #717168 - Flags: review?(catlee)
(Assignee)

Comment 35

5 years ago
Comment on attachment 716127 [details] [diff] [review]
configs

This was http://hg.mozilla.org/build/buildbot-configs/rev/f0c04d1e7c28
Attachment #716127 - Flags: checked-in+

Updated

5 years ago
Attachment #717168 - Flags: review?(catlee) → review+
(Assignee)

Comment 36

5 years ago
Comment on attachment 717168 [details] [diff] [review]
kill ubuntu32-b2g

http://hg.mozilla.org/build/puppet-manifests/rev/edbd9b502812
Attachment #717168 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.