837269 - Remove "Sent from my Firefox OS" tag line from email app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

STR
 (1) Compose email, send to yourself

Notice with embarrassment (who else did I send emails with this silly thing to?!??) that it includes the tagline 

--
Sent from my Firefox OS device.

I never agreed to that and there's no way to disable it.

I think this should block because it's a privacy issue.  Forcing users to include cheesy product plugs and thereby reveal personal information in all their emails is Not The Mozilla Way.

Just being able to opt out would make me happy.  I don't care to configure the tag line.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Privacy might be pushing it a little since we intentionally put a 'User-Agent' header with the value 'Mozilla Gaia Email Client 0.1alpha' in all messages we compose for consistency with all other well-behaved mail clients, but I agree that we should disable the default signature.

The string was meant for a joke for an early demo; it's *not localized* and as Chris says, there's no way to change it from the UI (out-of-scoped from v1) and it's a pretty annoying default.  Risk for fixing this is very low; effort is to change one constant to a null from a string and minor fix-ups to the unit tests to clobber the signature back into existence because the tests like signatures to be present to get as much coverage as possible.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

iPhone has a similar string, as an editable line that you can remove...

"Sent from my iPhone"

Adding :stas and :pike so that they are aware that the string is going to be removed.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

It's too late to discuss adding in the ability to edit that tag line, it should be removed from the builds asap.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Attachment: remove the constant, fix the tests; does not affect existing profiles!: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/123

This fixes the problem by removing the entire concept of the default signature from the app.

This *will not* fix existing accounts; they will continue to have the default.  We have a few ways to fix existing accounts:
- Disable the signature injection logic entirely.
- Have the account migration logic for when we upgrade nuke the signature; trigger a database upgrade to cause this to happen.  We could key on db version and be less nukey maybe or something.
- Just tell all current dog-fooders delete their accounts and re-create after this lands.


In terms of STR, it seems that we only inject the signature on reply/forward, not on compose.  And the text is in the compose field and editable, but we put it after what we quote and our compose field has various bugs about its sizing, so you might not see it.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia-email-libs-and-more/master:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/123

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/8069

gonna see if the automated(?) uplift magicks this.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 9595bb1a185011d61cd48f9009027a13da4869cd
v1.0.0: a77081ef92654889e50147ffb2ff86ba906034ce

Comment 7

[mdaniloff]

Reproduceable on Unagi build 20130214070203
"Sent from my Firefox OS" message appears inside the body of the email 
Gaia:6544fdb8dddc56f1aefe94482402488c89eeec49
Gecko:http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/d1288313218e

Note:
This is not reproducing on:
Build id 20130214032850
"gaia" remote="hgmozillaorg" revision="6ba3c0dfb2ee"/> 
"gecko" remote="hgmozillaorg" revision="aceeea086ccb"/>

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

(In reply to mdaniloff from comment #7)
> Reproduceable on Unagi build 20130214070203
> "Sent from my Firefox OS" message appears inside the body of the email 

(In reply to Andrew Sutherland (:asuth) from comment #4)
> This fixes the problem by removing the entire concept of the default
> signature from the app.
> 
> This *will not* fix existing accounts; they will continue to have the
> default.  We have a few ways to fix existing accounts:
> - Disable the signature injection logic entirely.
> - Have the account migration logic for when we upgrade nuke the signature;
> trigger a database upgrade to cause this to happen.  We could key on db
> version and be less nukey maybe or something.
> - Just tell all current dog-fooders delete their accounts and re-create
> after this lands.

Is the reproduction on an account created after the fix landed?

Comment 9

[amiller]

Does not make sense to create a regression issue.

Comment 10

[mdaniloff]

Verified Fixed on Unagi:
"Sent from my Firefox OS device" message does not appear on device
Unagi Build ID: 20130329070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/56c922308fd1
Gaia: 0a9f78bffafda93a159c1f502e8b110c2f49a500