837277 - [B2G] [Contacts][Facebook]: Incorrect birthday on contact page from imported facebook contact

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Misty Byrd]

Attachment: contact page note birthday December 28

Description:
The imported Facebook contact birthday information is not the matching the correct Facebook profile birthday information. This is happens on several contacts, especially if profile birthday is August or September, the contact birthday is December (month only issue), and October profile birthday, contact birthday is September (month and date issue) and others.

Prerequisites:
1.	Have a valid Facebook account with several Facebook friends with birthdays  to  verify.

Repro Steps:
1) Updated to Unagi Build ID: 20130201070203
2) Select contacts app
3) Select contacts settings (upper right corner)
4) Enable Facebook
5.) Enter log in information for Facebook account 
6.) Select log in
7.) Choose Select all facebook friends
8.) Select Import
9.) Once import is complete, Open an imported contact
10.) Verify contact page birthdate 
11.) From contact page select “View Facebook profile”
12.) Verify profile birthdate either on profile page or in about information (scoll down to basic info> birthday



Expected:
Contact information should match the Facebook profile information

Actual:
Imported Facebook contact birthday information is not the matching the correct Facebook profile birthday information.

Repro frequency:
2 devices, 100% repro of birthday discrepancy
 

Notes:
Kernel: Dec 5 
Gecko: 51daa19d4045669303b77807d5832568e2d1f686
Gaia: 4d1087307c7377b1d4c7d72ba2e90e63cdb8fbc4
** screen shots and logs attached **

Comment 1

[Misty Byrd]

Attachment: facebook profile note birthday August 28

Comment 2

[Misty Byrd]

Attachment: contact logs

Comment 3

[Misty Byrd]

Attachment: facebook profile

Comment 4

[Misty Byrd]

This issue repro in:

Build Id: 20130130070201
Kernel:  Dec 5th 
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/4593f3e765eb

Gaia   f7f5a0cd17e3d04308cc5850b254947e127122b9

Test Suite Name:  Facebook
UCID: owd-13749
Test case: # 5258

https://moztrap.mozilla.org/runtests/run/712/env/296/?pagenumber=1&pagesize=100&sortfield=order&sortdirection=asc&filter-id=5258

Incorrect birthday on contact page from imported facebook contact

Comment 5

[Chris Kreinbring [:CKreinbring]]

Still repros in Unagi version 20130204070201
Gecko: 2aa2cbcc4e4bc667770eaeaad9c36efeadc1674a
Gaia: b277f372f097c77dd2ec1988a80e458280dda491
Kernal: Dec 5

Comment 6

[Jose Manuel Cantera]

should be fixed

Comment 7

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

The problem was about parsetInt and the radix. If the string begins with "0x", the radix is 16 (hexadecimal) by default so months among 01-09 were December for us. It could be fixed parseInt('monthFromFB', 10). Although I prefer delete all code and how we know the date format we can create a new Date given the date string provided by FB directly.

Comment 8

[Misty Byrd]

Smoketest:
Unagi: Build ID: 20130205070201
Kernel: Dec 5 
Gecko: 2c84784b9dc17cc7b2eff6af82ccb94270eb6106
Gaia: 5f97bb66a70e0e61b1604f2572dc88cbbc140a10 
This issue repros, the Incorrect birthday on contact page from imported facebook.

Comment 9

[Jose Manuel Cantera]

Attachment: Pointer to GH 7978 PR

Comment 10

[Jose Manuel Cantera]

(In reply to crdlc from comment #7)
> Created attachment 710163 [details]
> Patch v1
> 
> The problem was about parsetInt and the radix. If the string begins with
> "0x", the radix is 16 (hexadecimal) by default so months among 01-09 were
> December for us. It could be fixed parseInt('monthFromFB', 10). Although I
> prefer delete all code and how we know the date format we can create a new
> Date given the date string provided by FB directly.

We cannot do that because some contacts do not disclose their birth year, that's why I'm proposing this alternative patch.

thanks!

Comment 11

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/69cbf046f40d74d94e6d830c84755b75be239a6f

Comment 12

[Cristian Rodriguez (:crdlc)]

Comment on attachment 710567 [details]
Pointer to GH 7978 PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: wrong months 
Testing completed: yes
Risk to taking this patch (and alternatives if risky): close to null

Comment 13

[Misty Byrd]

Smoketest regression:
This issue still repros in:
build#20130206
Kernel: Dec 5th
Gecko  a63eb9592fab5ccd3a3ad87767b3117f328710df
Gaia   9f5a4a9f6d321dbb4805f1f98623e770b0e89698

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 27734835e6a1eea9aec9c8984f450ac148b11fe4

Comment 15

[Misty Byrd]

Smoketest regression:
This issue still repros in:
build#20130207070202
Kernel: Dec 5th
Gecko  cf1b9d27345e70daf242514733f848e76241ea1d
Gaia   7e54ca673277b20b1d91d18477dc44d6ad226761

Comment 16

[Misty Byrd]

Verified fixed in:

Kernel Dec 5th

build#20130208070201

Gecko  83f9c2a31c6404282c3bd44dd2e5c5a3d2b2b539


Gaia   cff23a80c41b7de223d27c6a6f1f82f95c9c5f6b

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1