convert css3-box-shadow tests to CSSWG format

ASSIGNED
Assigned to

Status

()

Core
Layout: Misc Code
ASSIGNED
5 years ago
4 years ago

People

(Reporter: Gérard Talbot, Assigned: Gérard Talbot)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This bug is to track patches for exporting and converting the css3-box-shadow tests in
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/box-shadow/
to the CSSWG repository. See 
CSSWG Test Format 
http://wiki.csswg.org/test/css2.1/format 
and bug 691950 for background info.

assigned -> me as of now
(Assignee)

Comment 1

5 years ago
Created attachment 709566 [details] [diff] [review]
Patch for box-shadow tests

Notes on the patch and on tests
===============================

8 tests to **_not_** shift over: 
boxshadow-blur.html
boxshadow-blur-notref.html
boxshadow-blur-notref2.html
boxshadow-blur-2.html
boxshadow-blur-2-ref.html
boxshadow-blur-2-notref.html
boxshadow-dynamic.xul
boxshadow-dynamic-ref.xul


10 tests and/or reftests using unneedlessly red:
boxshadow-mixed.html
boxshadow-mixed-ref.html
boxshadow-multiple.html
boxshadow-multiple-ref.html
boxshadow-onecorner.html
boxshadow-onecorner-ref.html
boxshadow-twocorners.html
boxshadow-twocorners-ref.html
boxshadow-threecorners.html
boxshadow-threecorners-ref.html
They all have a <!-- comment --> indicating so.



3 tests with fractional pixels, deliberately testing fractions of a pixel: 
boxshadow-rounding.html
boxshadow-skiprect.html
boxshadow-skiprect-ref.html



8 tests and/or reftests that generate a too tall document box:
boxshadow-onecorner.html
boxshadow-onecorner-ref.html
boxshadow-twocorners.html
boxshadow-twocorners-ref.html
boxshadow-threecorners.html
boxshadow-threecorners-ref.html
tableboxshadow-trshadow.html
tableboxshadow-trshadow-ref.html



4 filename-renamed tests and/or reftests:
611574-1.html is now inner-shadow-with-inset-001.html
611574-1-ref.html is now inner-shadow-with-inset-001.html
611574-2.html is now inner-shadow-with-inset-002.html
611574-2-ref.html is now inner-shadow-with-inset-002-ref.html
(Assignee)

Comment 2

4 years ago
> 4 filename-renamed tests and/or reftests:
> 611574-1.html is now inner-shadow-with-inset-001.html
> 611574-1-ref.html is now inner-shadow-with-inset-001.html

It should have been written 
611574-1-ref.html is now inner-shadow-with-inset-001-ref.html

The patch does not have such error:

rename from layout/reftests/box-shadow/611574-1-ref.html
rename to layout/reftests/box-shadow/inner-shadow-with-inset-001-ref.html
You need to log in before you can comment on or make changes to this bug.