837356 - sut_lib soft_reboot_and_verify sometimes prints out "Remote Device Error:" even in success conditions.

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

I suspect this is a large part of some of the sheriff issue's we've been seeing lately [todo tie to bugs]

Especially on the pandas.

So what happens is if waitForDevice fails 3 times in a row, we print the Remote Device Error, and then pass back into the softreboot loop, which tries 5 seperate times as well to reboot+wait.

If it succeeds the second time (which is very common) all is well for THIS script, but buildbot sees "Remote Device Error" in the log and throws its hands up, "ooo infra error, ok lets fail out"

When the actual buildbot "steps" didn't return failure either.

I'm not sure atm what the best fix here is, but a fix does need to be made.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: don't print out

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 710344 [details] [diff] [review]
don't print out

I was hoping for a more in depth audit/solution, but forgot I was buildduty this week so I can't invest as much (if any) time as I'd like. Lets go with this pending a possible better choice, I'll deploy it tomorrow

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

landed in the build/tools repository, feel free to make this a leave open bug for a larger scale cleanup.

Comment 4

[Justin Wood (:Callek)]

Deployed just now.

For tracking sanity I'm resolving this bug, and we can do new bugs once we get further along in cleanups.