837386 - Hook up MailNews message display to the Safe Browsing code to improve the scam warning

Status: NEW

(SeaMonkey :: MailNews: Message Display, defect)

Description

[rsx11m]

Now that bug 477718 has made the Safe Browsing code available in SeaMonkey, it should be utilized for the MailNews message display to get better results for the rather unsatisfactory Scam Warning feature. It may be just reusing the same info bar if a match is found, or a different info bar similar to the browser warning to distinguish a rule-based trigger from a list-based trigger.

(Quoting rsx11m from bug 836769 comment #4)
> (In reply to Philip Chee from bug 836769 comment #2)
> > A more complicated issue is to make our suite/mailnews/phishingDetector.js also
> > check the phish/malware tables when any mail message containing dubious links is
> > viewed. At the moment our phishingDetector.js just does static checks, I think.
> 
> Yes, it's just a fixed set of rules (see Thunderbird meta bug 654502).
> Making it use the tables to improve the scam warning certainly would be a
> plus. On the other hand, one may argue that it should be sufficient already
> to show the browser's warning when clicking on a link.

Comment 1

[Philip Chee]

Just adding my notes here so that they don't get lost.
Thunderbird phishingDetector.js calls mPhishingWarden.isEvilURL()
http://hg.mozilla.org/comm-central/annotate/511e66705f3f/mail/base/content/phishingDetector.js#l158
Which calls MultiTableQuerier
http://hg.mozilla.org/comm-central/annotate/511e66705f3f/mail/components/phishing/list-warden.js#l137
Which is here:
http://hg.mozilla.org/comm-central/annotate/511e66705f3f/mail/components/phishing/list-warden.js#l163
Now all this is based on a very old fork of the Firefox v2.0 safe browsing code.

As far as I know the multi-table query code is currently at:
http://mxr.mozilla.org/seamonkey/source/toolkit/components/url-classifier/content/multi-querier.js
But that code hasn't been touched since 2006 and probably hasn't been tested/used since then.