Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Port bug 774315 (ability to hide placeholder for click to play)

RESOLVED FIXED

Status

SeaMonkey
UI Design
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

5 years ago
* Close box doesn't work
* No Modern theme support for the close box
* No context menu options to play/hide plugin
(Assignee)

Comment 1

5 years ago
Created attachment 709383 [details] [diff] [review]
WIP

If you can't wait for the context menu changes, feel free to r+ this (if appropriate) and I'll attach the context menu changes later.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #709383 - Flags: feedback?(philip.chee)
(Assignee)

Comment 2

5 years ago
Created attachment 709430 [details] [diff] [review]
Right-click on CTP plugin activates it

Necessary before we can even think about giving it a context menu entry, and we probably also want to land this part on branches too.
Attachment #709430 - Flags: review?(philip.chee)

Comment 3

5 years ago
Comment on attachment 709383 [details] [diff] [review]
WIP

close button is invisible in modern.

> -            for (let plugin of plugins) {
> -              let overlay = doc.getAnonymousElementByAttribute(plugin, "class", "mainBox");
> +            for (var plugin of plugins)
Any reason for changing this from let to var?
Attachment #709383 - Flags: feedback?(philip.chee)
(Assignee)

Comment 4

5 years ago
Created attachment 711511 [details] [diff] [review]
Right-click on CTP plugin activates it

Now checking the correct button (oops!)
Attachment #709430 - Attachment is obsolete: true
Attachment #709430 - Flags: review?(philip.chee)
(Assignee)

Comment 5

5 years ago
Created attachment 711520 [details] [diff] [review]
Make the close box work

In Classic, at least... I'll patch Modern separately.
Attachment #709383 - Attachment is obsolete: true
Attachment #711511 - Attachment is obsolete: true
Attachment #711520 - Flags: review?(philip.chee)
(Assignee)

Comment 6

5 years ago
(In reply to Philip Chee from comment #3)
> (From update of attachment 709383 [details] [diff] [review])
> > +            for (var plugin of plugins)
> Any reason for changing this from let to var?
I had to edit the line anyway ;-)
(Assignee)

Comment 7

5 years ago
Created attachment 711553 [details] [diff] [review]
Modern theme support

Including the necessary bits of bug 831921 (i.e. excluding the unnecessary bits, which looked awful when I tried it out...)
Attachment #711553 - Flags: review?(philip.chee)

Comment 8

5 years ago
Comment on attachment 711520 [details] [diff] [review]
Make the close box work

r=me
Attachment #711520 - Flags: review?(philip.chee) → review+

Comment 9

5 years ago
Comment on attachment 711553 [details] [diff] [review]
Modern theme support

>    color: white;
[I think modern should use #FFFFFF].

> +  text-shadow: 0 0 3.5px rgba(0, 0, 0, 0.8);
>    border-radius: 12px;
You have a radius of 12px but our close.gif is pretty square-ish so it looks too close to the rounded corner.

In winstripe further down I see:


> :-moz-handler-clicktoplay .mainBox {
....
>   border-radius: 2.5px;
Setting the border radius to 2.5px makes our close.gif look more snug.

....
>   text-shadow: none;
>   box-shadow: none;
I am unsure if the above two styles make the CTP box look better or worse.

>  :-moz-handler-clicktoplay .icon,
So I assume you decided not to set this to contentPluginClickToPlayPlain.png like winstripe. Any reason? OK it looks pretty ugly to me.

>  :-moz-handler-vulnerable-updatable .icon,
>  :-moz-handler-vulnerable-no-update .icon {
>    background-image: url(chrome://mozapps/skin/plugins/contentPluginClickToPlay.png);
Attachment #711553 - Flags: review?(philip.chee)

Comment 10

5 years ago
Comment on attachment 711553 [details] [diff] [review]
Modern theme support

>> :-moz-handler-clicktoplay .mainBox {
> ....
>>   border-radius: 2.5px;
> Setting the border radius to 2.5px makes our close.gif look more snug.
r=me with the border radius set to 6px as discussed over IRC.
Attachment #711553 - Flags: review+
(Assignee)

Comment 11

5 years ago
Comment on attachment 711520 [details] [diff] [review]
Make the close box work

Pushed comm-central changeset 918a7b8058ee.
(Assignee)

Comment 12

5 years ago
Comment on attachment 711553 [details] [diff] [review]
Modern theme support

Pushed comm-central changeset 8a31b4fc6ce4.
(Assignee)

Comment 13

5 years ago
Comment on attachment 711553 [details] [diff] [review]
Modern theme support

Pushed comm-central changeset d2957730cfd1 for the review comment.
(Assignee)

Comment 14

5 years ago
I'm going to resolve this and open a new bug for the context menu.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(In reply to neil@parkwaycc.co.uk from comment #14)
> I'm going to (...) open a new bug for the context menu.

Did you?
(Assignee)

Updated

4 years ago
Blocks: 858995
(Assignee)

Comment 16

4 years ago
(In reply to Jens Hatlak from comment #15)
> (In reply to comment #14)
> > I'm going to (...) open a new bug for the context menu.
> 
> Did you?

No, sorry. I've just filed bug 858995.
You need to log in before you can comment on or make changes to this bug.