837433 - the auto-completion popup of the Web Console is offset to the top

Status: RESOLVED DUPLICATE of bug 785433

(DevTools :: Console, defect)

Description

[Florent Fayolle]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:21.0) Gecko/20130202 Firefox/21.0
Build ID: 20130202030955

Steps to reproduce:

1. Open the Web Console
2. Type (do *not* paste this) : pr
   |=> you should be proposed some completions
3. Enter <space> then <backspace>


Actual results:

On Linux, the completion popup appears at the top of the area it appeared first (on Linux).

Note that the origin of this issue is probably the same as this one on Firebug:
http://code.google.com/p/fbug/issues/detail?id=6197


Expected results:

At the end of the above steps, the completion popup should appear immediately at the top of the command Textbox.

Comment 1

[Loic]

Did you see this behavior in previous versions of Firefox?

If not, could you use mozregression tool to find a regression range, please:
http://harthur.github.com/mozregression/ (e.g mozregression -good=2012-08-01)

Comment 2

[Mihai Sucan [:msucan]]

Florent: do you see the popup opening in wrong locations? If yes, this bug will be fixed by bug 831693.

Comment 3

[Florent Fayolle]

> If not, could you use mozregression tool to find a regression range
mozregression has an odd bug on my configuration. For nightlies before October, I just lose the keyboard when typing inside the window.

I'll fill a bug.

> Florent: do you see the popup opening in wrong locations? If yes, this bug will be fixed by bug 831693.
Yes. I imagine I have to compile Firefox if I want to test your patch.

Florent

Comment 4

[Florent Fayolle]

> > If not, could you use mozregression tool to find a regression range
> mozregression has an odd bug on my configuration. For nightlies before October, I just lose the keyboard when typing inside the window.
Bug filed here: https://github.com/mozilla/mozregression/issues/59

Comment 5

[Alice0775 White]

I can reproduce in Firefox19 and later, but in 18.

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/1e56d3016820
Mozilla/5.0 (X11; Linux i686; rv:18.0) Gecko/18 Firefox/18.0a1 ID:20120920030543
Bad:
http://hg.mozilla.org/mozilla-central/rev/48c4938eaf57
Mozilla/5.0 (X11; Linux i686; rv:18.0) Gecko/18 Firefox/18.0a1 ID:20120921030601
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1e56d3016820&tochange=48c4938eaf57

Suspected: Bug 789482

[Note] Bug 789482 was backed out in 18beta

Comment 6

[Girish Sharma [:Optimizer]]

This is due to the fact that the popup is set to appear below the input area but the webconsole is at the bottom of the page. Add to this the fact that there are some fancy repainting stuff going on while opening the popup, it overlaps the input area, or sometimes have an offset from it.

This is fixed in bug 831693.

Feel free to resolve duplicate it.

Comment 7

[Florent Fayolle]

I git clone'd Mozilla Central and I applied the patch attached in this comment: 
https://bugzilla.mozilla.org/show_bug.cgi?id=831693#c47

Then I compiled the project and ran Firefox.

In Firebug the problem isn't solved and in WebConsole the auto-completion isn't working anymore.

Did I do the right steps to apply try the patch?

> This is fixed in bug 831693.
I'd like to test the patch before marking this bug as fixed.

Florent

Comment 8

[Girish Sharma [:Optimizer]]

(In reply to fayolle-florent from comment #7)
> I git clone'd Mozilla Central and I applied the patch attached in this
> comment: 
> https://bugzilla.mozilla.org/show_bug.cgi?id=831693#c47
> 
> Then I compiled the project and ran Firefox.
> 
> In Firebug the problem isn't solved and in WebConsole the auto-completion
> isn't working anymore.

The issue faced in Firebug is totally different, changing Firefox code will not fix that. That has to be done from Firebug side and please open a issue on their github repository.

> Did I do the right steps to apply try the patch?

> > This is fixed in bug 831693.
> I'd like to test the patch before marking this bug as fixed.

It works absolutely fine for me. I have pushed the patch again for try, you can download the build and test it out after the try is complete from https://tbpl.mozilla.org/?tree=Try&rev=22e6dbd651a9

Resolving duplicate of bug 785433 as that one is older and has the same issue.

Comment 9

[Mihai Sucan [:msucan]]

Florent: thank you for the bug report!


(In reply to fayolle-florent from comment #3)
> > If not, could you use mozregression tool to find a regression range
> mozregression has an odd bug on my configuration. For nightlies before
> October, I just lose the keyboard when typing inside the window.
> 
> I'll fill a bug.
> 
> > Florent: do you see the popup opening in wrong locations? If yes, this bug will be fixed by bug 831693.
> Yes. I imagine I have to compile Firefox if I want to test your patch.

Yes, or you can wait for bug 831693 to land, then you can test a Firefox nightly to see if this bug is fixed or not.

(In reply to fayolle-florent from comment #7)
> I git clone'd Mozilla Central and I applied the patch attached in this
> comment: 
> https://bugzilla.mozilla.org/show_bug.cgi?id=831693#c47
> 
> Then I compiled the project and ran Firefox.
> 
> In Firebug the problem isn't solved and in WebConsole the auto-completion
> isn't working anymore.
> 
> Did I do the right steps to apply try the patch?

I tested the patch for bug 831693 and it works for me. I am not sure what went wrong for you. Take a look at:

https://developer.mozilla.org/en-US/docs/Developer_Guide

... maybe you find something you've missed in working with the git clone, or with building Firefox.

Also, you might want to test with the fx-team repository. In your git repo, fx-team should be a branch you can checkout.


> > This is fixed in bug 831693.
> I'd like to test the patch before marking this bug as fixed.

Sure, feel free to reopen this bug if you find the problem you reported is not fixed by bug 831693 once it lands.


(In reply to Girish Sharma [:Optimizer] from comment #8)
> (In reply to fayolle-florent from comment #7)
> > I git clone'd Mozilla Central and I applied the patch attached in this
> > comment: 
> > https://bugzilla.mozilla.org/show_bug.cgi?id=831693#c47
> > 
> > Then I compiled the project and ran Firefox.
> > 
> > In Firebug the problem isn't solved and in WebConsole the auto-completion
> > isn't working anymore.
> 
> The issue faced in Firebug is totally different, changing Firefox code will
> not fix that. That has to be done from Firebug side and please open a issue
> on their github repository.

From reading the Firebug issue report I am not sure this is an entirely different issue. However, you are right that the fix from bug 831693 will not fix the issue users see with Firebug.

The reasoning is simple: both the Web Console and Firebug use a xul:panel for the autocomplete popup. We are both affected by the Gecko-level xul:panel bugs.

The fix in bug 831693 simply works around the xul:panel issue, for the Web Console popup only. If we'd fix the xul:panel implementation - things would work better in Firebug as well.

Comment 10

[Timothy Nikkel (:tnikkel)]

(In reply to Mihai Sucan [:msucan] from comment #9)
> From reading the Firebug issue report I am not sure this is an entirely
> different issue. However, you are right that the fix from bug 831693 will
> not fix the issue users see with Firebug.
> 
> The reasoning is simple: both the Web Console and Firebug use a xul:panel
> for the autocomplete popup. We are both affected by the Gecko-level
> xul:panel bugs.
> 
> The fix in bug 831693 simply works around the xul:panel issue, for the Web
> Console popup only. If we'd fix the xul:panel implementation - things would
> work better in Firebug as well.

Is there a bug filed for this gecko level panel bug?

Comment 11

[Mihai Sucan [:msucan]]

(In reply to Timothy Nikkel (:tn) from comment #10)
> Is there a bug filed for this gecko level panel bug?

I haven't seen a bug report about this specific issue. However xul:panels are known to have a number of important issues - focus issues, resize, reposition issues, etc. We have a few bug reports about them.

Comment 12

[Timothy Nikkel (:tnikkel)]

Can we get a bug report about the specific issue you mentioned here? And please file the other issues. The chance of them getting fixed drops dramatically if there is no bug filed.

Comment 13

[Mihai Sucan [:msucan]]

(In reply to Timothy Nikkel (:tn) from comment #12)
> Can we get a bug report about the specific issue you mentioned here? And
> please file the other issues. The chance of them getting fixed drops
> dramatically if there is no bug filed.

Reported bug 842380 - not the best bug report, since I'm missing a test case and investigation. Someone who knows the xul:panel implementation should be able to investigate the issue better/quicker than me.

Comment 14

[Florent Fayolle]

@Mihai: tested right now and it works fine, indeed.

Also thanks for having reporting the bug.

Florent