Closed Bug 837570 Opened 7 years ago Closed 7 years ago

Fix OSX64 buildage from |Bug 780561 - (new-packager) Overhaul the packager|

Categories

(SeaMonkey :: Build Config, defect, blocker)

x86
macOS
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.18

People

(Reporter: ewong, Assigned: Callek)

Details

Attachments

(1 file, 1 obsolete file)

The packager was overhauled in bug 780561 and it broke a few
items in c-c's OSX64 packaging stage.

This bug is to fix the redness in OSX64 tbpl.
Summary: Port |Bug 780561 - (new-packager) Overhaul the packager| to SeaMonkey → Fix OSX64 buildage from |Bug 780561 - (new-packager) Overhaul the packager|
Severity: normal → blocker
OS: Windows Vista → Mac OS X
Attached patch Fix OSX64 build patch (v1) (obsolete) — Splinter Review
I've compared the recent trunk with what was done in bug 780561, specifically
https://bug780561.bugzilla.mozilla.org/attachment.cgi?id=695970, and only
came up with this.
Attachment #709611 - Flags: feedback?(bugspam.Callek)
Attached patch [c-c] v1Splinter Review
So, attachment 709611 [details] [diff] [review] indeed is not enough to fix this bug.

Per chat with :glandium just now, I think this will fix us, key points being TB landed http://hg.mozilla.org/comm-central/rev/d82d65b26412 to fix them, we however don't use that in our mozconfig ...
http://hg.mozilla.org/comm-central/file/511e66705f3f/suite/config/mozconfigs/macosx-universal/nightly

We override topsrcdir, so that we pull the file in from m-c directly, rather than c-c's copy. Which was legacy work-arounds.

Because of that, we never get this new change to be sure we use the right dir.

Even with this patch, I'm now a bit skeptical of the l10n path being correct for l10n on trunk, but we can check that a bit later.
Assignee: ewong → bugspam.Callek
Attachment #709611 - Attachment is obsolete: true
Attachment #709611 - Flags: feedback?(bugspam.Callek)
Attachment #709620 - Flags: review?(ewong)
Attachment #709620 - Flags: review?(ewong) → review+
Comment on attachment 709620 [details] [diff] [review]
[c-c] v1

https://hg.mozilla.org/comm-central/rev/ca30e347561c

Leaving open to see if this fixes it
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.18
You need to log in before you can comment on or make changes to this bug.