Closed
Bug 837637
Opened 13 years ago
Closed 13 years ago
data-reporting notification shouldn't create its own notification box
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 21
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
2.10 KB,
patch
|
Gavin
:
review+
jaws
:
feedback+
|
Details | Diff | Splinter Review |
Bug 836010 added <notificationbox id="global-notificationbox"/> to browser.xul. This should be used for the data-reporting notification.
Attachment #709681 -
Flags: review?(gavin.sharp)
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → dao
|
||
Comment 1•13 years ago
|
||
Comment on attachment 709681 [details] [diff] [review]
patch
Review of attachment 709681 [details] [diff] [review]:
-----------------------------------------------------------------
Can you please also update the code at http://hg.mozilla.org/mozilla-central/annotate/2a8e243711a9/browser/base/content/browser-syncui.js#l69 ?
Attachment #709681 -
Flags: feedback+
|
|
Assignee | |
Comment 2•13 years ago
|
||
(In reply to Jared Wein [:jaws] from comment #1)
> Can you please also update the code at
> http://hg.mozilla.org/mozilla-central/annotate/2a8e243711a9/browser/base/
> content/browser-syncui.js#l69 ?
That's more complicated, as there are sync-specific XBL bindings for that notificationbox and notification.
|
||
Updated•13 years ago
|
Attachment #709681 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
You need to log in
before you can comment on or make changes to this bug.
Description
•