837637 - data-reporting notification shouldn't create its own notification box

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Bug 836010 added <notificationbox id="global-notificationbox"/> to browser.xul. This should be used for the data-reporting notification.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 709681 [details] [diff] [review]
patch

Review of attachment 709681 [details] [diff] [review]:
-----------------------------------------------------------------

Can you please also update the code at http://hg.mozilla.org/mozilla-central/annotate/2a8e243711a9/browser/base/content/browser-syncui.js#l69 ?

Comment 2

[Dão Gottwald [:dao]]

(In reply to Jared Wein [:jaws] from comment #1)
> Can you please also update the code at
> http://hg.mozilla.org/mozilla-central/annotate/2a8e243711a9/browser/base/
> content/browser-syncui.js#l69 ?

That's more complicated, as there are sync-specific XBL bindings for that notificationbox and notification.

Comment 3

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e460b09f2e44

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e460b09f2e44