[Dialer] Implement new startup loading events

RESOLVED FIXED in Firefox OS v2.0

Status

P2
normal
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: julienw, Assigned: Eli)

Tracking

({perf})

unspecified
2.0 S4 (20june)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

(Whiteboard: [c=automation p=3 s= u=])

Attachments

(1 attachment)

We need to measure when the app is usable by the user. For that we'll need to send an event (the moment is specific to the app) to |window| that the performance test will be able to receive.

The event name can be "x-moz-perf-user-ready" amongst all apps so that the performance test can be similar.

For the Dialer, it should be triggered when a number can be dialed (ie: the touch events are registered).
Blocks: 837633
No longer depends on: 837633
Summary: "ready to use" perf measurement → [Dialer] "ready to use" perf measurement
Depends on: 837139

Updated

5 years ago
Keywords: perf
Whiteboard: [c=instrumentation p=]
Priority: -- → P2

Updated

5 years ago
Whiteboard: [c=instrumentation p=] → [c=automation p= s= u=]

Updated

4 years ago
Blocks: 996043
(Assignee)

Updated

4 years ago
Assignee: nobody → eperelman
Whiteboard: [c=automation p= s= u=] → [c=automation p=3 s= u=]
(Assignee)

Updated

4 years ago
Blocks: 996038
(Assignee)

Comment 1

4 years ago
Bug 996038 introduces new events outlining the phases of application startup. Each of these 5 events needs to be implemented.
Summary: [Dialer] "ready to use" perf measurement → [Dialer] Implement new startup loading events
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 8435878 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20150
Attachment #8435878 - Flags: review?(hub)
Attachment #8435878 - Flags: review?(etienne)
Comment on attachment 8435878 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20150

Rock on!
Attachment #8435878 - Flags: review?(etienne) → review+

Updated

4 years ago
Depends on: 1019037
I like it, but I can't give a r+ yet, as there is some side effect that the fix for bug 1019037 will address.

Cheers,
Comment on attachment 8435878 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20150

Please wait for bug 1019037 to land before checking this in.
Attachment #8435878 - Flags: review?(hub) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/d1625a4f0ea23945e0d9ead86a93cb9dbedb2638
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

4 years ago
Target Milestone: --- → 2.0 S4 (20june)
we would like to request uplift for 2.0. blocking bug is already 2.0+

risk: low
blocking-b2g: --- → 2.0?
lets do gaia approval here for 2.0.

Updated

4 years ago
blocking-b2g: 2.0? → ---
(Assignee)

Comment 9

4 years ago
Requesting uplift to 2.0 as it is important for meeting our release performance acceptance criteria [1].

[1] https://wiki.mozilla.org/FirefoxOS/Performance/Release_Acceptance
status-b2g-v2.0: --- → ?
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
status-b2g-v2.0: ? → ---
(Assignee)

Comment 10

4 years ago
Comment on attachment 8435878 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20150

Low risk, see comment 9.
Attachment #8435878 - Flags: approval-gaia-v2.0?(bbajaj)
(Assignee)

Updated

4 years ago
status-b2g-v2.0: --- → affected
status-b2g-v2.1: --- → fixed
Can you please help fill the approval request comment on this ?

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TBPL]:
[Risks and why]: 
[String/UUID change made/needed]:
Flags: needinfo?(eperelman)
(Assignee)

Comment 12

4 years ago
Requesting uplift to 2.0 as it is important for meeting our release performance acceptance criteria.

[Feature/regressing bug #]: bug 996038
[User impact if declined]: none
[Describe test coverage new/current, TBPL]: Feature only triggers events for testing, no user-facing features or tests
[Risks and why]: Low, as there are no user-perceived changes
[String/UUID change made/needed]: n/a
Flags: needinfo?(eperelman)
Keywords: checkin-needed

Updated

4 years ago
Attachment #8435878 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
You need to log in before you can comment on or make changes to this bug.