837772 - Work - Get mochitest-plain and mochitest-chrome running in Metro Firefox

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

We currently have a way to run mochitest-browser-chrome tests for Metro Firefox (see bug 771271).  We would also like to run "plain" and "chrome" mochitests too.  This should help us test web-facing features, and let us share tests with Desktop Firefox and with Fennec.

Comment 2

[Matt Brubeck (:mbrubeck)]

The following command creates a tests.ini file in dist/bin and launches the Metro browser, but for some reason the command line from tests.ini doesn't seem to make it to the BrowserCLH command-line handler:

$ pymake EXTRA_TEST_ARGS=--metro-immersive mochitest-plain

Comment 3

[Matt Brubeck (:mbrubeck)]

The code in nsBrowserApp that reads tests.ini is always dropping the last argument.  For mochitest-browser-chrome the last argument is always "about:blank" so this doesn't matter, but for other suites it does.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Since the final argument is usually not followed by a space, we don't usually end up incrementing newArgc an extra time after reading it.  The only time we need to decrement newArgc is if we stopped reading right after incrementing it.

This loop is a bit tricky to read; maybe we can rewrite it as two nested loops?

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 716268 [details] [diff] [review]
patch

(In reply to Matt Brubeck (:mbrubeck) from comment #4)
> Created attachment 716268 [details] [diff] [review]
> patch
> 
> Since the final argument is usually not followed by a space, we don't
> usually end up incrementing newArgc an extra time after reading it.  The
> only time we need to decrement newArgc is if we stopped reading right after
> incrementing it.
> 
> This loop is a bit tricky to read; maybe we can rewrite it as two nested
> loops?

I have no issues with this. Although with your fix if it works perfectly, .. iiibdfi?

Comment 6

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Another option is to have the system do the command line processing for us with CommandLineToArgvW [1]

[1] http://msdn.microsoft.com/en-us/library/windows/desktop/bb776391%28v=vs.85%29.aspx

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3cbaeb1f128

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c3cbaeb1f128