Closed
Bug 837775
Opened 12 years ago
Closed 12 years ago
Many UseValueOf warnings produced by lint
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 21
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
|
1.93 KB,
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
I looked at the lint warnings in bug 716748, specifically the UseValueOf ones. Most of them are in libraries we build as part of Fennec (e.g. httpclientandroidlib, json-simple, and sync code) but a couple had easy fixes.
CCing rnewman to see if we can get fixes for the ones in sync code or we should just ignore those.
Attachment #709784 -
Flags: review?(bnicholson)
|
||
Updated•12 years ago
|
Attachment #709784 -
Flags: review?(bnicholson) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [leave open]
Target Milestone: --- → Firefox 21
|
|
||
Comment 2•12 years ago
|
||
(Sorry, was on PTO.)
Ignore the ones in upstream libraries; that's what we do with other warnings there, too.
I'll file a bug for these in Sync. Some of them are already covered by Jenkins, and we just knock them down when we feel motivated to do so (e.g., Bug 734316).
Thanks for producing the dump in Bug 716748!
Whiteboard: [leave open]
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•