837792 - Preprocessed files should depend on #include'd files

Status: RESOLVED DUPLICATE of bug 935305

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

If a preprocessed file has a #include, the #include'd file(s) aren't captured as dependencies in the make rule (only the main input file is a dep). Therefore if one of the #include'd files changes, the make rule does not run.

We should probably generate .deps files when running Preprocessor.py and incorporate them into the make rules.

This problem will go away with Tup, of course.

Comment 1

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #0)
> This problem will go away with Tup, of course.

The problem would go away with tup, but even when we support tup, we can't rely on this, can we? (since we'll support multiple backends)

Comment 2

[Gregory Szorc [:gps]]

(In reply to Mike Hommey [:glandium] from comment #1)
> (In reply to Gregory Szorc [:gps] from comment #0)
> > This problem will go away with Tup, of course.
> 
> The problem would go away with tup, but even when we support tup, we can't
> rely on this, can we? (since we'll support multiple backends)

Correct.