Last Comment Bug 837799 - Allow building of NSS against older sqlite
: Allow building of NSS against older sqlite
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.14.2
: All All
: P1 normal (vote)
: 3.14.3
Assigned To: Kai Engert (:kaie)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-04 11:15 PST by Kai Engert (:kaie)
Modified: 2013-02-04 12:09 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1 (584 bytes, patch)
2013-02-04 11:22 PST, Kai Engert (:kaie)
wtc: review+
Details | Diff | Review

Description Kai Engert (:kaie) 2013-02-04 11:15:23 PST
In bug 578561 we started to make use of the new SQLITE_FCNTL_TEMPFILENAME file control.

However, because that patch made use of that symbol, we currently have a build time dependency on newer NSS.

In some stable environments it might be required to still build against older sqlite - and we shouldn't block people from being able to build newer NSS.

I propose that we remove the build time dependency, and instead use the following code in NSS:

#ifndef SQLITE_FCNTL_TEMPFILENAME
#define SQLITE_FCNTL_TEMPFILENAME 16
#endif

Based on the description that Richard gave in bug 578561 comment 53 I conclude that sqlite never changes the numeric values of such codes, and that it's therefore fine to use the raw number.
Comment 1 Kai Engert (:kaie) 2013-02-04 11:19:58 PST
FYI, I'm proposing this addition to NSS, in order to allow building of newer NSS against older versions of sqlite on older maintained Linux branches, which want to pick up NSS for security reasons, but are not ready to pick up newer sqlite.
Comment 2 Kai Engert (:kaie) 2013-02-04 11:22:27 PST
Created attachment 709806 [details] [diff] [review]
Patch v1

who is willing to bless this patch? thanks in advance
Comment 3 Wan-Teh Chang 2013-02-04 11:36:22 PST
Comment on attachment 709806 [details] [diff] [review]
Patch v1

Review of attachment 709806 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. I agree we should do this.

Please add a comment:
  /* SQLITE_FCNTL_TEMPFILENAME was added in SQLite 3.7.15.*/
or
  /* Added in SQLite 3.7.15.*/

This will help future NSS maintainers know when this can be
removed.
Comment 4 Kai Engert (:kaie) 2013-02-04 11:59:29 PST
Wan-Teh, thank you very much for the quick review.

Checked in including comment.

Checking in sdb.c;
/cvsroot/mozilla/security/nss/lib/softoken/sdb.c,v  <--  sdb.c
new revision: 1.31; previous revision: 1.30
done

Note You need to log in before you can comment on or make changes to this bug.