The default bug view has changed. See this FAQ.

Allow building of NSS against older sqlite

RESOLVED FIXED in 3.14.3

Status

NSS
Libraries
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kaie, Assigned: kaie)

Tracking

3.14.2
3.14.3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In bug 578561 we started to make use of the new SQLITE_FCNTL_TEMPFILENAME file control.

However, because that patch made use of that symbol, we currently have a build time dependency on newer NSS.

In some stable environments it might be required to still build against older sqlite - and we shouldn't block people from being able to build newer NSS.

I propose that we remove the build time dependency, and instead use the following code in NSS:

#ifndef SQLITE_FCNTL_TEMPFILENAME
#define SQLITE_FCNTL_TEMPFILENAME 16
#endif

Based on the description that Richard gave in bug 578561 comment 53 I conclude that sqlite never changes the numeric values of such codes, and that it's therefore fine to use the raw number.
(Assignee)

Comment 1

4 years ago
FYI, I'm proposing this addition to NSS, in order to allow building of newer NSS against older versions of sqlite on older maintained Linux branches, which want to pick up NSS for security reasons, but are not ready to pick up newer sqlite.
(Assignee)

Comment 2

4 years ago
Created attachment 709806 [details] [diff] [review]
Patch v1

who is willing to bless this patch? thanks in advance
Assignee: nobody → kaie
Attachment #709806 - Flags: superreview?(rrelyea)
Attachment #709806 - Flags: review?(wtc)

Comment 3

4 years ago
Comment on attachment 709806 [details] [diff] [review]
Patch v1

Review of attachment 709806 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. I agree we should do this.

Please add a comment:
  /* SQLITE_FCNTL_TEMPFILENAME was added in SQLite 3.7.15.*/
or
  /* Added in SQLite 3.7.15.*/

This will help future NSS maintainers know when this can be
removed.
Attachment #709806 - Flags: review?(wtc) → review+
(Assignee)

Updated

4 years ago
Attachment #709806 - Flags: superreview?(rrelyea)
(Assignee)

Comment 4

4 years ago
Wan-Teh, thank you very much for the quick review.

Checked in including comment.

Checking in sdb.c;
/cvsroot/mozilla/security/nss/lib/softoken/sdb.c,v  <--  sdb.c
new revision: 1.31; previous revision: 1.30
done
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.14.3

Updated

4 years ago
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.