837824 - Add a way to run an explicit make target in a directory

Status: NEW

(Firefox Build System :: Mach Core, enhancement)

Description

[Marco Bonardo [:mak]]

I was trying to make check in the storage/ folder, and figured out mach doesn't support that yet.

Comment 1

[Gregory Szorc [:gps]]

This is really a request to "run make target X in directory Y."

How do people think we should handle this? Here are some options:

./mach build -t check storage
./mach build storage:check
./mach build -d storage check

Comment 2

[Mike Hommey [:glandium]]

I'd say mach build storage:check or mach build storage check

Comment 3

[Mike Hommey [:glandium]]

maybe the latter, with the possibility to give several. (mach build storage foo bar baz)

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I have to admit I know little about make check, but wouldn't it make sense to treat it like, say, make reftest and give it a dedicated mach command?

Comment 5

[Gregory Szorc [:gps]]

(In reply to Mike Hommey [:glandium] from comment #3)
> maybe the latter, with the possibility to give several. (mach build storage
> foo bar baz)

The problem with |mach build storage targetA targetB| is that as currently implemented you can give multiple directories/targets with |mach build|. e.g. |mach build services toolkit browser|. This is *extremely* handy. We need some way to distinguish positional arguments. Using a delimiter or named argument are how we do that, I think.

Comment 6

[(not currently active) Ted Mielczarek]

(In reply to :Ms2ger from comment #4)
> I have to admit I know little about make check, but wouldn't it make sense
> to treat it like, say, make reftest and give it a dedicated mach command?

+1 for mach check (mach chech? mach czech?)

Comment 7

[Marco Bonardo [:mak]]

I also like mach check target1 target2 ... (if possible)