837843 - 20130204 21.0a1 nightly load hangs if browser shutdown while on about:compartments page

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Michael Kraft [:morac]]

After updating from the 20130103 21.0a1 nightly load to the 20130104 21.0a1 nightly load, I'm finding that if I try to exit the browser while the about:compartments page is open.  When I reverted back to the 20130103 build this problem went away.

Good: http://hg.mozilla.org/mozilla-central/rev/ba515e203813
Bad: http://hg.mozilla.org/mozilla-central/rev/847e28c7ba67


Steps to reproduce:

1. Create new profile
2. Run Firefox
3. Go to "about:compartments"
4. Reload page (not really necessary, but for good measure).
5. Close window or choose File->Exit

Expected results:  Browser quits
Actual results: Browser hangs after window closes

Unfortunately I don't have admin on the machine I'm using currently so I can't debug the shutdown process, but the last thing I see in the console log before it hangs is:

*** LOG addons.xpi: shutdown


It's possible this might be a core bug, but the latest Windows SeaMonkey build is 20130130 so I can't test with SeaMonkey.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I see this with today's Nightly on Windows 8.

Comment 2

[B.J. Herbison]

My experience is somewhat different.
- The first time I closed Nightly 21 with about:compartments open I did not see a hang.
- When I reopened Nightly and closed it again (about:compartments still open) I did see the hang.
- When I killed the hung process, restarted Nightly, closed about:compartments and exited, I still saw the hang.
- Starting Nightly again and exiting there was no hang.

I saw the same behavior on 32 and 64 bit versions:
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:21.0) Gecko/20130204 Firefox/21.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130204 Firefox/21.0
Using Windows 7. I did not create a new profile for the tests.

Comment 3

[Alice0775 White]

Regrerssion window
Good:
http://hg.mozilla.org/mozilla-central/rev/ba515e203813
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130202 Firefox/21.0 ID:20130202222319
Bad:
http://hg.mozilla.org/mozilla-central/rev/31268d71c33c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130202 Firefox/21.0 ID:20130203063220
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ba515e203813&tochange=31268d71c33c

Regressed by:
31268d71c33c	Olli Pettay — Bug 833143 - Don't GC in nsXREDirProvider::DoShutdown, r=bsmedberg,billm

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Boo. Backing out Bug 833143.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I'll do it tomorrow morning unless someone else does it before that.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Bug 833143 backed out.

https://hg.mozilla.org/mozilla-central/rev/2360c3c46aca

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking, please set status flag to 'affected' if this comes up again after a re-landing over in bug 833143.