Closed
Bug 837872
Opened 12 years ago
Closed 12 years ago
test-manifest.ini references a 404 NOT FOUND location
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
Details
Attachments
(1 file)
771 bytes,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
https://github.com/mozilla/mozbase/blob/master/test-manifest.ini#L6
refers to
https://github.com/mozilla/mozbase/blob/master/manifestdestiny/README.txt
. This now no longer exists. There is a resource,
https://github.com/mozilla/mozbase/blob/master/manifestdestiny/README.md
, but it just points to
http://mozbase.readthedocs.org/en/latest/manifestdestiny.html . We
should probably just use this to link to.
Reporter | ||
Comment 1•12 years ago
|
||
Attachment #710042 -
Flags: review?(wlachance)
Comment 2•12 years ago
|
||
Comment on attachment 710042 [details] [diff] [review]
proposed fix
I would personally just take out the link altogether as it's IMO not that useful and liable to get out of date again. But this is also fine.
Attachment #710042 -
Flags: review?(wlachance) → review+
Reporter | ||
Comment 3•12 years ago
|
||
pushed: https://github.com/mozilla/mozbase/commit/7f200e66bb1639fbbc8db2bb2362740b46bb7a00
I tend towards leaving the URL in. If we're committed to readthedocs as our long-term solution, then this URL should not change unless we significantly change our code structure or documentation strategy. I've also heard a lot of complaints about the manifest format being hard to find the documentation for so I am inclined to keep this here.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•