Closed
Bug 837988
Opened 8 years ago
Closed 8 years ago
Remove 1.9.1 and 2.0 builders from the builders config.
Categories
(SeaMonkey :: Release Engineering, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ewong, Assigned: ewong)
Details
Attachments
(1 file, 3 obsolete files)
40.64 KB,
patch
|
ewong
:
review+
|
Details | Diff | Splinter Review |
Both 1.9.1 and 2.0 are obsolete and won't be updated. They should be removed from the list of builders.
![]() |
Assignee | |
Updated•8 years ago
|
OS: Windows Vista → All
![]() |
Assignee | |
Comment 1•8 years ago
|
||
![]() |
Assignee | |
Comment 2•8 years ago
|
||
Also removed the mozconfigs.
Attachment #710014 -
Attachment is obsolete: true
Attachment #710014 -
Flags: review?(bugspam.Callek)
Attachment #710017 -
Flags: review?(bugspam.Callek)
Comment 3•8 years ago
|
||
Comment on attachment 710017 [details] [diff] [review] Remove comm-2.0 and comm-1.9.1 from build configs (v2) Review of attachment 710017 [details] [diff] [review]: ----------------------------------------------------------------- Assuming the passes checkconfig r+=me. ::: seamonkey/release_master.py @@ +291,1 @@ > #cvsroot=releaseConfig['cvsroot'], lets just rip out the comment/code finally :-) @@ +347,1 @@ > #cvsroot=cvsroot, same here
Attachment #710017 -
Flags: review?(bugspam.Callek) → review+
![]() |
Assignee | |
Comment 4•8 years ago
|
||
Attachment #710017 -
Attachment is obsolete: true
Attachment #714194 -
Flags: review+
![]() |
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 714194 [details] [diff] [review] Remove comm-2.0 and comm-1.9.1 from build configs (v3) diff --git a/seamonkey/release_master.py b/seamonkey/release_master.py - # Disable cvsroot on comm-central/comm-2.0 builds - #cvsroot=releaseConfig['cvsroot'], + # Disable cvsroot on comm-central builds Callek, do I even need this comment here? @@ -338,18 +337,17 @@ for platform in releaseConfig['enUSPlatf project=releaseConfig['productName'], appName=releaseConfig['appName'], brandName=releaseConfig['brandName'], repoPath=releaseConfig['sourceRepoPath'], mozRepoPath=releaseConfig['mozillaRepoPath'], inspectorRepoPath=releaseConfig['inspectorRepoPath'], venkmanRepoPath=releaseConfig['venkmanRepoPath'], chatzillaRepoPath=releaseConfig['chatzillaRepoPath'], - # Disable cvsroot on comm-central/comm-2.0 builds - #cvsroot=cvsroot, + # Disable cvsroot on comm-central builds or here even? Since I've removed the commented line anyway.
Attachment #714194 -
Flags: review+ → review?(bugspam.Callek)
Comment 6•8 years ago
|
||
Comment on attachment 714194 [details] [diff] [review] Remove comm-2.0 and comm-1.9.1 from build configs (v3) Review of attachment 714194 [details] [diff] [review]: ----------------------------------------------------------------- kill those comments
Attachment #714194 -
Flags: review?(bugspam.Callek) → review+
![]() |
Assignee | |
Comment 7•8 years ago
|
||
Attachment #714194 -
Attachment is obsolete: true
Attachment #717415 -
Flags: review+
![]() |
Assignee | |
Comment 8•8 years ago
|
||
Pushed to buildbot-configs: http://hg.mozilla.org/build/buildbot-configs/rev/7bd2cbcd8864
![]() |
Assignee | |
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•