838031 - [Calendar][User Story] Separate detail and edit views

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)

Description

[Peter Dolanjski [:pdol]]

UCID: Calendar-050

User Story:
As a user, when viewing the details of a calendar entry, by default, I want to enter a view-only mode to avoid accidental edits. I want to explicitly enter an edit mode to modify the entry.

Comment 2

[Casey Yee]

Proposal is to follow the same pattern as contacts. From the event, the user can enter an "edit" mode to make changes.

Comment 3

[Kevin Grandon :kgrandon]

Hi Casey - What's the schedule look like for getting wires/screens for this?

Comment 4

[Casey Yee]

It's scheduled for our next sprint which is due Tuesday.

cc. Rob which is working on this one.  He will be providing the specs.

Comment 5

[Rob MacDonald [:robmac]]

(In reply to Kevin Grandon from comment #3)
> Hi Casey - What's the schedule look like for getting wires/screens for this?

Hi Kevin - I just posted the initial spec to dropbox...

https://www.dropbox.com/s/ii6ngj6iq22fbnx/calendar-editmode.pdf

Let me know if you have any questions. - Rob

Comment 6

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 7

[James Lal [:lightsofapollo]]

Comment on attachment 718526 [details]
Github pull request pointer

Nice job :) Thanks for putting up with the somewhat lengthy review. I feel like this is nicely fleshed out now though.

Comment 8

[James Lal [:lightsofapollo]]

landed in master: https://github.com/mozilla-b2g/gaia/commit/d6c1f416f9e72aab2065c6b22b6cd1c1c4241a18

Comment 9

[Kevin Grandon :kgrandon]

Attachment: Current implementation - show event view

Hi Rob - 

Attached is the current implementation of the calendar show event page. Just adding this here for your information. Please followup with me if you think we can make the visuals better. Thanks!

Comment 10

[Kevin Grandon :kgrandon]

FYI - here is the current state of interactions with the new page:

- If an event is readonly, we disable the edit button.
- Clicking on an event or alarm takes you to the event view.
- Pressing back on the event view takes you to the top view.
- After creating an event, return to the top view.
- After editing  an event, return to the event view.
- Pressing back on the event view after saving returns to the top page.

Comment 11

[Jason Smith [:jsmith]]

I was planning on looking into this, but if you want to steal and get to this first, go right ahead.

Comment 12

[Askeing Yen[:askeing][:fyen]]

Attachment: Multi_Lines_in_Notes_Edit_Mode

There are multi-lines content in notes field, the read-only mode cannot displays it the same as edit mode does.

Comment 13

[Askeing Yen[:askeing][:fyen]]

Attachment: Multi_Lines_in_Notes_Readonly_Mode

Comment 14

[Askeing Yen[:askeing][:fyen]]

Attachment: Long title and where

Long title and where text also have display problem.

Comment 15

[Rob MacDonald [:robmac]]

Hi Kevin and Przemek...

Kevin, the interactions look good. Let's continue to tweak the visuals once we get feedback from Przemek in visual design.

Przemek, please take a look at the screens in dropbox (https://www.dropbox.com/s/ii6ngj6iq22fbnx/calendar-editmode.pdf) and let us know when you can provide us with your feedback and/or visuals.

- Rob

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit d6c1f416f9e72aab2065c6b22b6cd1c1c4241a18 as:
v1-train: d2905153a7118005fbecb1af9e572c5c271c4210

Comment 17

[Jason Smith [:jsmith]]

Going to steal this back per today's meeting - I'm going to writing test cases for this, so might as well test this as well. If you found bugs in your screenshots, feel free to file followup bugs linked to this bug (and also indicate what testing you've done).

Comment 18

[Jason Smith [:jsmith]]

Test Cases for User Story

* Test that when I access an offline event off the month view that the event details are shown in read only mode
* Test that when I access an offline event off the week view that the event details are shown in read only mode
* Test that when I access an offline event off the day view that the event details are shown in read only mode
* Test that when I select to edit an offline event from a read only view of an event that I am taken to the edit event view
* Test that if I hit back from editing an offline event that I am taken back to the read only view for that event
* Test that if I hit back from editing an offline event and select to edit the event again that I will be taken to the edit event view
* Test that if I save an offline event update and select to edit the event from the read only view that I go to the edit event view
* Test that when I access a google calendar event that I see the event in read only mode
* Test that when I access a yahoo calendar event that I see the event in read only mode
* Test that when I access a caldav calendar event that I see the event in read only mode
* Test that when I save an event update for google calendar that I see the updates in a read only view
* Test that when I save an event update for yahoo calendar that I see the updates in a read only view
* Test that when I save an event update for caldav calendar that I see the updates in a read only view
* Test that when I view an event with a long event title, location, and notes that the event information is readable in a read only view
* Test that when I view an event with no alarms that no alarm reminders is shown in the read only view
* Test that when I view an event with a single alarm that the correct alarm reminder is shown in the read only view
* Test that when I view an event with two alarms that two alarm reminders are shown with the correct time in the read only view
* Test that when I view an event in the read only view with UTF-8 characters in the name, location, and notes that the correct name, location, and notes are shown
* Test that I can view an imported event in read only view while that calendar for that event is being synced

Comment 19

[Jason Smith [:jsmith]]

Kevin & James - Can you take a look at the test cases proposed in comment 18 to see if they look okay? Anything you think I'm missing? Any general feedback? Comments? Etc.

Comment 20

[Rob MacDonald [:robmac]]

Hi everyone - 

I hope this isn't coming too late, but here's the link to the visual design layout:

https://www.dropbox.com/s/qdl7xj6vc6n6yr7/Event_Details_Spec.png

Also, in talking with QA, we thought it would improve the flow if, upon editing an event, the user would be returned directly to the calendar view. This saves the extra step of backing out of the read-only event view after an item has been edited. However, if the user were to cancel an event edit, they would be returned to the event read-only view. 

I'll make the changes to the spec an re-upload it.

In the meantime, let me know if you have any questions or concerns.

Comment 21

[Kevin Grandon :kgrandon]

(In reply to Jason Smith [:jsmith] from comment #18)
> Test Cases for User Story

Hi Jason, these test cases look good to me!

(In reply to Rob MacDonald [:robmac] from comment #20)
> Hi everyone - 
> 
> I hope this isn't coming too late, but here's the link to the visual design
> layout:
> 
> https://www.dropbox.com/s/qdl7xj6vc6n6yr7/Event_Details_Spec.png


Hi Rob,

Thanks for the spec. This looks good to me, I guess I just had a few questions:

1 - Alarm display, I'm assuming we want to display alarms on the view page?
2 - Start/End dates. It might be hard to handle multi-day events in this format, how should we display those?

Comment 22

[Jason Smith [:jsmith]]

I think I'm actually okay with review on Kevin on this one, although James can feel free to add his comments on this.

Comment 23

[Jason Smith [:jsmith]]

Just finished getting this into MozTrap.

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=1672

Comment 24

[Rob MacDonald [:robmac]]

(In reply to Kevin Grandon :kgrandon from comment #21)
> 
> 1 - Alarm display, I'm assuming we want to display alarms on the view page?

Yes, that would be correct. It could go directly under the meeting room.

> 2 - Start/End dates. It might be hard to handle multi-day events in this
> format, how should we display those?

If it's a multi-day event, let's use the following:

From Tuesday, February 17, 8:00am
to Thursday, February 19, 9:00pm

Also, based on Jason's feedback, I made a modification to the flow in the spec. Now if you tap "Done" in edit mode, it goes straight back to the calendar view.

Here's the flow:

https://www.dropbox.com/s/ii6ngj6iq22fbnx/calendar-editmode.pdf

I'm traveling for the next few days but feel free to flag Casey if there are any urgent issues.

Comment 25

[Jason Smith [:jsmith]]

Completed a lot of exploratory testing on this today and filed some bugs appropriately. There's more formal testing that will come from this soon, but we can mark this verified for now that this definitely has been initially looked at.