mozprocess tests should clean up after themselves

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: k0scist, Assigned: k0scist)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
In hooking up the mozprocess tests for `make check` (bug 790765), it
is observed that mozprocess tests leave around some litter:

"""
│hg st
? testing/mozbase/mozprocess/tests/iniparser/dictionary.o
? testing/mozbase/mozprocess/tests/iniparser/iniparser.o
? testing/mozbase/mozprocess/tests/iniparser/libiniparser.a
? testing/mozbase/mozprocess/tests/iniparser/libiniparser.so.0
? testing/mozbase/mozprocess/tests/proclaunch
"""

While this has slid by for development purposes, we don't want this on
m-c.  Instead the mozprocess tests should clean up after themselves.
If there is a case where we want to keep these around, we can add a
command line flag to do so or similar, but for the 99% use case we
want these gone.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=778267
(Assignee)

Updated

6 years ago
Blocks: 790765
(Assignee)

Updated

6 years ago
Assignee: nobody → jhammel
(Assignee)

Updated

6 years ago
See Also: → bug 778267
(Assignee)

Comment 1

6 years ago
Created attachment 722579 [details] [diff] [review]
clean up and some more stuff

So this kinda falls into the category of "a lot more than needs to be done for bug 838075, not nearly enough to fix bug 778267" In addition to using setUpClass and tearDownClass which are 2.7isms, I've combined these into one file and class as I see no reason they should't be.  Consequently, some test names have changed.  I renamed the whole test_mozprocess.py instead of "mozprocess1.py" or what not.

As for the things that I didn't clean up, I'll write you a novella sometime.
Attachment #722579 - Flags: review?(wlachance)
Comment on attachment 722579 [details] [diff] [review]
clean up and some more stuff

Nice.
Attachment #722579 - Flags: review?(wlachance) → review+
(Assignee)

Comment 3

6 years ago
pushed: https://github.com/mozilla/mozbase/commit/3a628434ad9a508d0a3ae8b29ca196bbef9d3025
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.