838104 - Need to add start up animation for customization.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kai-Chih Hu [:khu]]

For customization. 

Need to make sure these animations are added for the release of customized build. Assets need to be provided by partners.

Comment 1

[David Palomino [:dpalomino]]

cc'ing Beatriz and Daniel. Nominating as tef?

Comment 2

[Alex Keybl [:akeybl]]

Already blocking tef-spain-custom, not a tef+ blocker as this won't land in our tree.

Comment 3

[Kai-Chih Hu [:khu]]

Proposal for the sequence of start up animation is: OEM animation -> carrier animation -> Firefox OS animation.

Comment 4

[Kai-Chih Hu [:khu]]

David, since we are using CSS for power off animation, can we follow the same way to do the animation or can we remove this requirement? Thank you.

Comment 5

[David Palomino [:dpalomino]]

Hi Kevin, 

Requirement is still necessary, power up animation is a custom requirement. Not sure about CSS is the best way to implement that or if there's any other method. 

Cc'ing vendor... 

Thanks!
David

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

Hi David,

Power UP animation is being worked on.

it is the power OFF animation that needs further discussion. Currently the power off animation is just the orange circle dropping from top down. This is done by CSS, not some kind of image/animation. If power off animation is to be as fancy as power up animation (the nice splash screen), the power off animation part of the code needs to be re-written (basically a newly added feature). so Kevin is asking if the power off animation requirement can be removed.

Thanks

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Rex will help me on this issue. Thank you Rex!

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

Rex, i believe there are some work needed to allow the customization of start up animation. can you confirm? Thanks

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

We need
1. to animate from carrier logo to FFOS logo.
2. to copy customized animation file to correct path of system app at build time.
I Just wrote some code to slightly shorten showing time of FFOS logo (3s -> 2s), and animating from OEM logo to FFOS logo which works.  I would see how to do step 2 in customization script which Yuren is working on.

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

TEF? need to enable customiz-ability 
or else cannot have carrier logo to show before FXOS logo

Comment 11

[David Palomino [:dpalomino]]

Thanks to all for your help, 

Just to highlight that this is required for tef customization, and it's an important issue during certification. 

So, I will add the dep to meta cert bug.

Comment 12

[Patryk Adamczyk [:patryk] UX]

This need visual design approval before it gets integrated so please notify me or [e-mail] for feedback.

Comment 13

[Kai-Chih Hu [:khu]]

(In reply to David Palomino [:dpv] from comment #11)
> Thanks to all for your help, 
> 
> Just to highlight that this is required for tef customization, and it's an
> important issue during certification. 
> 
> So, I will add the dep to meta cert bug.

David, are you talking about power off animation? Comparing with start up animation, power off is not so important. Currently, we only support CSS. Can we remove power off animation from current version? Thanks.

Comment 14

[Kai-Chih Hu [:khu]]

(In reply to Patryk Adamczyk [:patryk] UX from comment #12)
> This need visual design approval before it gets integrated so please notify
> me or [e-mail] for feedback.

Hi, Patryk, may I know what detailed information needs to be reviewed by visual design team? Thanks.

Comment 15

[David Palomino [:dpalomino]]

Hi Kevin, 

I think we should maintain power off animations, let us discuss if it's possible to get a css version of the animation, and let u know. 

Thanks!
David

Comment 16

[Kai-Chih Hu [:khu]]

Thanks, David. Could you please include Yuren and me into the discussion if it's needed? Yuren may help to see what can be integrated into current Firefox OS. Thanks.

Comment 17

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Pull request

First try.
The usage, and the structure of customization package would be similar to bug 838110,
with
<customize dir>/power/carrierPoweron.mp4
or
<customize dir>/power/carrierPoweron.png
corresponding to customized carrier animation or picture.

Tim, may you review this patch?  Thank you!

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 717855 [details]
Pull request

Please re-request for review.

Comment 19

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 717855 [details]
Pull request

Fixed through the commit.  (with some refactioring)
The filename are now
<customize dir>/power/carrier_power_on.png
and
<customize dir>/power/carrier_power_on.mp4

Tim, may you review it again?  Thanks for the help!

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 717855 [details]
Pull request

For get to mention -- would you write unit tests for the new init_logo_handler.js?

Comment 21

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 717855 [details]
Pull request

Thanks for reviewing Tim!
I'm working on unit test now.  If I didn't catch up until 2/28, let's fire a new bug to land the unit test. 

Setting feedback request to Patryk.  Please tell me if any info is needed.

Comment 22

[Andrew Overholt [:overholt]]

Maybe Peter can provide feedback since Patryk is at MWC.

Comment 23

[Peter La]

Hi KM Lee/Tim,

Is there a spec you are working from in terms of adding this customization?  Can you share it with me so I know what the intentions were and I can properly review it?

What I will need is to look at this sequence running on the device.  My main goal is to just make sure that we're not putting something out there that is potentially unattractive in any way, visually.  As far as conforming with what our partners want, I can only compare it to what they spec'd out for you (presumably).

So I need 2 things:

1. Is there a spec for this customization?  Where can I get it?
2. How can I load this onto my device?  I do have the ability to sync to a branch and build it myself (may need a bit of help with the exact branch/commands).

Comment 24

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Hi Peter:
Thanks for your help.  To summarize, this customization inserts a carrier logo (or animation) before OS logo when power on the phone.

Case 1: (Carrier) puts a mp4 video as power-on logo:  The video is played once Gaia is loaded.  After the video is over, it is faded out to our usual OS logo.  OS logo lasts 2 seconds then it is faded out to show lockscreen.

Case 2: (Carrier) puts a png image as power-on logo: The image is shown once Gaia is loaded.  The image lasts at least 2 seconds, then faded out to our usual OS logo.  The OS logo also lasts 2 seconds, then it is faded out to show lockscreen.  (Images would actually last longer because system app is loading in background)

Case 3: No customization asserts found: Shows only firefox OS logo as usual, then faded out to show lockscreen

The fade-out transition used here are all the same one as current version.


To load this customization I conclude the step for this bug as below. you may also want to refer bug 838110:
1. suppose our customization dir is located in ~/gaia/customization.
2. copy a power-on image to ~/gaia/customization/power/carrier_power_on.png.
3. $ cd ~/gaia
4. $ CUSTOMIZE=./customization make install-gaia

then it's done (for case 2).  For case 1, just put the power-on video to ~/gaia/customization/power/carrier_power_on.mp4 instead, with all other steps the same.

Comment 25

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to KM Lee [:rexboy] from comment #24)
> then it's done (for case 2).  For case 1, just put the power-on video to
> ~/gaia/customization/power/carrier_power_on.mp4 instead, with all other
> steps the same.

Rex, is it possible to put an YouTube video here to show the sequence to Peter?

Comment 26

[KM Lee [:rexboy] (inactivate after Sep. 22)]

http://www.youtube.com/watch?v=_hCPy1yclIk

Video here.  I'm not having unagi at home so it's on b2g-desktop.  It works very similar on b2g-desktop except that unagi shows the customized picture slightly longer (due to loading).

Comment 27

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to KM Lee [:rexboy] from comment #26)
> http://www.youtube.com/watch?v=_hCPy1yclIk
> 
> Video here.  I'm not having unagi at home so it's on b2g-desktop.  It works
> very similar on b2g-desktop except that unagi shows the customized picture
> slightly longer (due to loading).

Thank you!!

Comment 28

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to KM Lee [:rexboy] from comment #26)
> http://www.youtube.com/watch?v=_hCPy1yclIk

You need to set the video from "private" to "unlisted".

Comment 29

[Peter La]

Hi,

Sorry for the delay.  I watched the video and, from a technical standpoint, what you are doing is fine.

I just don't quite understand the image being used... is that a placeholder or is that what the partners want?

At any rate, I think your implementation is good.  As long as you are replacing the image with the approved image provided by the partners, it should be alright.

Peter.

Comment 30

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Hi Peter:

It's just a placeholder here.  User (the carrier) may switch to a picture they want on build-time.
Thanks for the reviewing!

Comment 31

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Merged.

https://github.com/mozilla-b2g/gaia/commit/ba57c1d39c099edf6b5ae303ee5d1ad42ae02aba
Master

https://github.com/mozilla-b2g/gaia/commit/ae169d80bc72c524add5e173f413db8ef5e3d2e7
V1-train

https://github.com/mozilla-b2g/gaia/commit/554656c8dca1412c028afff2a354ff0698e9eb1a
v1.0.1

I will add a follow-up unit test bug.

Comment 32

[KM Lee [:rexboy] (inactivate after Sep. 22)]

The unit test of power on animation goes to bug 846620.

Comment 33

[John Ford [:jhford] CET/CEST Berlin Time]

Per comment 31, this is fixed on v1-train and v1.0.1

Comment 34

[amiller]

Does not make sense to create a regression issue.

Comment 35

[Darren]

Cannot verify, need steps to blackbox test this issue. I am not sure if I just need to check the Firefox OS or something more?

Comment 36

[John Hammink]

Please read the comments.  This requires powering the phone on and checking the order of animations.

Comment 37

[Darren]

Terkcell image and Firefox OS are displayed.

Verified fixed in build:
Build Identification: 20130405070205
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1d4c7fe3256e
Gaia: 2f64311e0f23b85c29b20be9502cbdeaee8342ae
RIL: Mozilla

Build Identification: 20130322070203
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4931ec89ebbe
Gaia: 85fd164691bb852f1cfaf82405df4380629ced6e
RIL: Mozilla

Comment 38

[Shally Li（leave from Mozilla）]

Per comment 37,I clear "Verifyme".