838167 - Add "Save Video" and "Save Video To" context menu options for html5 video

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: File Handling, defect)

Description

[Jim Mathies [:jimm]]

STR:

1) visit http://www.808.dk/?code-html-5-video
2) press-hold or right-click the video

results: no context menu is displayed
expected: context menu displayed with save options similar to images

Comment 1

[Jim Mathies [:jimm]]

We have a video detection here, but it doesn't appear to be working correctly.

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix v.1

Comment 3

[Jim Mathies [:jimm]]

Attachment: fix v.2

This depends on the patch in bug 837932.

On some sites, the element in popupNode was a XULElement, I'm guessing this was the video controls overlay. So I've moved this down to the loop where we walk up the tree looking for media or video elements.

Another oddity, on this site - 

http://www.808.dk/?code-html-5-video

the first element in the walk that we find is an nsIDOMHTMLVideoElement. That element supports nsIDOMHTMLMediaElement but the instanceof was failing for a check for that interface, so I check for both.

Comment 4

[Jim Mathies [:jimm]]

Attachment: save to patch v.1

This may come out depending on whether or not Asa decides to keep the save to options for images and video.

Comment 5

[Jim Mathies [:jimm]]

https://hg.mozilla.org/projects/elm/rev/dc37f97740e1
https://hg.mozilla.org/projects/elm/rev/fb839c10a5c4