838172 - Convert AudioChannelManager to WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 710207 [details] [diff] [review]
patch

Review of attachment 710207 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/AudioChannelManager.cpp
@@ +40,5 @@
>  
> +bool
> +AudioChannelManager::Headphones() const
> +{
> +  return mState == SWITCH_STATE_ON ? true : false;

return mState == SWITCH_STATE_ON;

@@ +41,5 @@
> +bool
> +AudioChannelManager::Headphones() const
> +{
> +  return mState == SWITCH_STATE_ON ? true : false;
> +}

Maybe inline this?

::: dom/webidl/AudioChannelManager.webidl
@@ +3,5 @@
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/.
> + */
> +
> +[NoInterfaceObject]

I don't think this is needed.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=f6d29f03e5fd

Comment 4

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=eb53d59bfe1a this is better

Comment 5

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/92f93ab32aec

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/92f93ab32aec