Closed Bug 838172 Opened 10 years ago Closed 10 years ago

Convert AudioChannelManager to WebIDL

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla21

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 2 obsolete files)

patch
14.16 KB, patch
baku
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #710207 -
        Flags: review?(peterv)

    
    

    
  
Comment on attachment 710207 [details] [diff] [review]
patch

Review of attachment 710207 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/AudioChannelManager.cpp
@@ +40,5 @@
>  
> +bool
> +AudioChannelManager::Headphones() const
> +{
> +  return mState == SWITCH_STATE_ON ? true : false;

return mState == SWITCH_STATE_ON;

@@ +41,5 @@
> +bool
> +AudioChannelManager::Headphones() const
> +{
> +  return mState == SWITCH_STATE_ON ? true : false;
> +}

Maybe inline this?

::: dom/webidl/AudioChannelManager.webidl
@@ +3,5 @@
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/.
> + */
> +
> +[NoInterfaceObject]

I don't think this is needed.

        Attachment #710207 -
        Flags: review?(peterv) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch (obsolete)
        — 
          — Splinter Review
      

    


  
https://tbpl.mozilla.org/?tree=Try&rev=f6d29f03e5fd

        Attachment #710207 -
        Attachment is obsolete: true

        Attachment #711752 -
        Flags: review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #711752 -
        Attachment is obsolete: true

        Attachment #711766 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/92f93ab32aec
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.