838175 - The Downloads Indicator doesn't turn green if tabs are on bottom

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20130205 Firefox/21.0
Build ID: 20130205031033

Steps to reproduce:
1. Launch Firefox
2. Go to about:config and set browser.tabs.onTop to false.
3. Perform several downloads.

Expected results:
After a download is completed the Downloads Indicator turns green.

Actual results:
The Downloads Indicator doesn't turn green.

Comment 1

[Simona Badau, Desktop QA]

Regression range:

Last good nightly: 2013-01-27
First bad nightly: 2013-01-28

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f18b12139151&tochange=80fed51ae074

Comment 2

[Simona Badau, Desktop QA]

The issue is reproducible also on the latest Aurora:

Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20130207 Firefox/20.0
Build ID: 20130207042017

Comment 3

[Marco Bonardo [:mak]]

one bug in that range is bug 831639

Comment 4

[Marco Bonardo [:mak]]

Mike, I wonder if any of those rules may override the finished status with the inverted icon

Comment 5

[Mike Conley (:mconley) (:⚙️)]

(In reply to Marco Bonardo [:mak] from comment #4)
> Mike, I wonder if any of those rules may override the finished status with
> the inverted icon

It's possible. I'll look into this today.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

(In reply to Marco Bonardo [:mak] from comment #4)
> Mike, I wonder if any of those rules may override the finished status with
> the inverted icon

That's exactly what's going on. These rules:

https://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/downloads/downloads-aero.css#28

Are not taking into account the downloads-indicator[attention] state.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Make the inverted toolbar icon rule not apply if the downloads-indicator is in its attention state.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 712443 [details] [diff] [review]
Patch v1

Easy fix - just added

#downloads-indicator:not([attention]) > #downloads-indicator-anchor >

to each rule.

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 712443 [details] [diff] [review]
Patch v1

Review of attachment 712443 [details] [diff] [review]:
-----------------------------------------------------------------

crazy stuff.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1.1

Patch v1 wasn't applying cleanly for some reason (though I can't see why it shouldn't - nothing bitrotted it). Anyhow, applied it manually, and attaching a new patch.

Pushed to inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c687b309a7a

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8c687b309a7a

Comment 12

[Marco Bonardo [:mak]]

Comment on attachment 712945 [details] [diff] [review]
Patch v1.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): downloads panel feature
User impact if declined: no downloads indicator glow when the button is on glass
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): limited to the feature, makes some css rules more specific
String or UUID changes made by this patch: none

Comment 13

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20130212 Firefox/21.0
Build ID: 20130212182646

Verified as fixed on the latest hourly tinderbox mozilla central build - the Downloads Indicator turns green after downloads are completed.

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.7.5.

Comment 14

[Marco Bonardo [:mak]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/91ab892b64b5

Comment 15

[Mihai Morar, (:MihaiMorar)]

(In reply to Simona B [QA] from comment #13)

I confirm the fix is verified on FF 20.b1 and Latest Nightly (2013-02-21)

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0(20130220104816)

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130221 Firefox/22.0(20130221072044)