83828 - Popups in Mac Classic have improper border.

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[Brad Tiffany]

In recent builds the popup menus under the Mac Classic theme lack black borders
on their top and left sides; they have white borders instead.  In popup.css, the
style is first set correctly for menupopup, but it is then overridden with bad
styling for menulist>menupopup.

Comment 1

[Joe Hewitt (gone)]

mac classic -> andreww

Comment 2

[Keyser Sose]

Has this been fixed in 0.9.2 or the latest builds?

Comment 3

[Brad Tiffany]

I'm still seeing this with build 2001071008.  Also, I think the rule in
popup.css I mentioned causes additional trouble. At
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/mac/popup.css there is

  1 menupopup, popup 
  2 {
  3 background-color      : Menu;
  4 border-left           : thin solid black;
  5 border-top            : thin solid black;
  6 border-right          : 3px ridge black;
  7 border-bottom         : 3px ridge black;
  8 -moz-user-focus                       : ignore;
  9 }

which is correct, followed by 

 32 menulist > menupopup,
 33 .menulist-menupopup 
 34 {
 35 border-left           : thin solid white;
 36 border-top            : thin solid white;
 37 border-right          : 3px ridge black;
 38 border-bottom         : 3px ridge black;
 39 background-color      : #DDDDDD;
 40 min-width                         : 0px;
 41 }

This is redundant (except for the min-width) with the first except that the
border color is botched and the background color is hardwired to its platinum
appearance value.  Unfortunately, the foreground color is MenuText (inherited
from elsewhere), so a light-text on dark-background theme gives popups with
white text on a grey background that can't be read.  Can min-width be moved and
this rule simply eliminated (it seems to work for me)?  Was this simply carried
over from the Windows version, where drop-down menulists do need different
styling from other menus?

Comment 4

[Alvaro Munoz-Aycuens]

WFM on Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:0.9.2+) Gecko/20010716 if i
understand the bug, when clicking on bookmarks the popup have the boders in
black with right border darker as seen in attachment

Comment 5

[Alvaro Munoz-Aycuens]

Sorry for the multiple attachments, problems with bug summiting

Comment 6

[Brad Tiffany]

Let me clarify.  Submenus are fine, as are contextual menus.  The preferences 
dialog, particularly the Appearance>Fonts panel, contain a number of the 
affected popups.  I'll attach a picture of what I see for the popup.

Comment 7

[Brad Tiffany]

Attachment: Illustration of affected popup from the fonts prefs

Comment 8

[Greg K.]

I confirm this bug.

Since Classic is supposed to mimic the appearance of Nav 4.x, it should be noted that Nav 
4.x for Mac OS displayed the popups Brad's referring to as boxes with white-colored 
background and a 1px solid black border, as well as a 1px solid black shadow to the right 
and bottom. This box is rendered offset 1px from the top of and -1px from the left of the 
popup control. This appearance mimics the "System 7"-style Mac OS appearance, not the 
later "Apple Platinum" appearance the present Classic theme is somewhat emulating.

Now, it seems Classic is actually trying to mimic Apple Platinum more; the popup controls 
themselves are Platinum-inspired. So, if we want these popups to really resemble 
Platinum-style popups, they should be styled as seen in "http://www.arstechnica.com/
reviews/1q00/macos-x-dp3/platinum-menu.gif" (which I'll attach hereon). Note that 
popup menus and menubar menus are styled identically as far as color and borders go.

Finally, the Platinum-style popups should be rendered directly on top of the popup 
control, with the selected value in the same position as shown on the control.

If the Asignee would like, I'll try to put together the proper CSS for the borders. How to 
accomplish the correct positioning is probably best handled by you.

Comment 9

[Greg K.]

Attachment: Reference of correct menu appearance (menubar and popup) under Apple Platinum and, thus, Mozilla Classic theme for Mac OS

Comment 10

[Greg K.]

See also bug 43554.

Comment 11

[Matthew T (active 1999-2002)]

Greg, the popup menu position bug is bug 52106.

(And yes, the aim is for the Classic theme to make Mozilla look like part of 
the OS, rather than to faithfully reproduce all the cosmetic bugs in 4.x.)

Comment 12

[andreww]

Attachment: changes to popup.css

fix ready to be reviewed and super-reviewed

Comment 13

[shliang]

Comment on attachment 58599 [details] [diff] [review]
changes to popup.css

r=shliang

Comment 14

[Blake Ross]

Comment on attachment 58599 [details] [diff] [review]
changes to popup.css

sr=blake

Comment 15

[andreww]

fix in trunk.

Comment 16

[Patty Mac]

Verified the patch.