83831 - Can't copy some messages from local mail to imap folder

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[David :Bienvenu]

I tried to copy a local message to an imap folder and it failed, with the imap
server complaining about the format of the message. I'll investigate this.

Comment 1

[David :Bienvenu]

nominating

Comment 2

[David :Bienvenu]

The problem is occuring in a folder which doesn't have X-Mozilla-Status lines in
the messages (not sure how this folder was generated). For some reason, this
causes us to try to send the envelope header when we append the local message to
the imap folder, which the imap server doesn't like, obviously.

Comment 3

[Navin Gupta]

I have also seen this sometimes but it is not reproducible always. The missing
mozilla status header may well be the reason. 

Comment 4

[David :Bienvenu]

changing summary - this only happens on some messages.

Comment 5

[Karen Huang]

dup of bug 83396?

Comment 6

[Karen Huang]

*** This bug has been marked as a duplicate of 83396 ***

Comment 7

[Karen Huang]

Verified as dup.

Comment 8

[Karen Huang]

Oops! I thought that they are the same bug.
Reopening this bug based on David comments from bug 83396....

Comment 9

[scottputterman]

how likely do you think this is to happen?  Your comments make it sound like
it's rare.  

Comment 10

[Navin Gupta]

I have seen this off and on and may have the culprit message in one of my local
folders. 

Comment 11

[Navin Gupta]

reassigning to self.

Comment 12

[Navin Gupta]

I have seen couple of error msg from the imap server:
i) message contains invalid header
ii) message has no header/body separator. 

but upon rebuilding the msf file if we copy the same header we don't get error
message. The important thing here is if we are copying a header that does 
i or ii we should make sure the copystate is cleared, this does not happen 
when we are copying multiple messages because we abort the copy. 

patch coming up to continue copying next message even if any one of them fails 
inbetween.

Comment 13

[Navin Gupta]

Attachment: proposed fix

Comment 14

[Navin Gupta]

requesting review from david. 

Comment 15

[David :Bienvenu]

please explain the fix - are the changes in both files required?

Comment 16

[Navin Gupta]

Yes, the changes are required. In protocol code we need to relax the condition 
so that the next message can be copied. Also we don't need to update the count
in the destination folder if the copy did not succeed. 

Comment 17

[scottputterman]

Navin, so these messages that are failing are valid messages that work correctly
when the local (or is it IMAP) .msf file is recreated?

Comment 18

[Navin Gupta]

when local.msf is recreated. 

Comment 19

[Navin Gupta]

david need review here also.

Comment 20

[David :Bienvenu]

r=bienvenu

Comment 21

[Scott MacGregor]

sr=mscott

Comment 22

[Navin Gupta]

fix checked in so that bad things (like not clearing copystate) do not happen.

Comment 23

[[e-mail] (gone - use [e-mail] instead)]

was this trunk only?  I am going through verifying bugs fixed on the trunk 
(with the possibility of going in on the branch later), do I need to verify 
this now, or can it wait?

Comment 24

[Navin Gupta]

yes, this was trunk only. It is not a contender for branch. 

Comment 25

[Henrik Gemal]

sure thing. copying a msg without X-Mozilla-Status line in it works.