Closed Bug 838312 Opened 11 years ago Closed 11 years ago

API for recording upload enabled preference

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Product:
Firefox Health Report Graveyard
Component:
Client: Desktop
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 21

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file)

Resilient upload flag recording, v1
7.40 KB, patch
rnewman
: review+
Details | Diff | Splinter Review 
In our rush to land FHR we didn't implement a unified API to record user choice for "set upload enabled flag." This meant that callers were responsible for triggering data deletion.

This patch adds an API to the policy to record the user's preference for whether FHR upload should be enabled. If upload is disabled, the policy schedules remote data deletion automagically. One less thing for callers to worry about and one less place where misbehaving callers could accidentally get us in trouble with the lawyers.

It's worth noting that the checkboxes in the preferences panes did not previously initiate deletion. They do now.
Attachment #710345 - Flags: review?(rnewman)
Attachment #710345 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/d9220b65d646
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla21
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: