838368 - Remove unused modules

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

From https://bugzilla.mozilla.org/show_bug.cgi?id=777639#c17:

(In reply to Mark Finkle (:mfinkle) from comment #17)
> Comment on attachment 709308 [details] [diff] [review]
> Part 2: Move sanitize.js to Sanitizer.jsm
> 
> 
> >diff --git a/mobile/android/modules/Makefile.in b/mobile/android/modules/Makefile.in
> 
> > EXTRA_JS_MODULES = \
> 
> >   linuxTypes.jsm \
> >   video.jsm \
> 
> We could probably remove these in a new bug
> 
> > EXTRA_PP_JS_MODULES = \
> >   contacts.jsm \
> 
> And this one too

Comment 1

[:Margaret Leibovic]

Attachment: patch

I went to file this bug and it already exists! And I'm cc'd!

We still need contacts.jsm until FormAutoComplete.js dies in bug 566746, so I can wait until then to land this. Or I could also kill FormAutoComplete.js myself so that Enn doesn't need to deal with it...

Comment 2

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #1)

> We still need contacts.jsm until FormAutoComplete.js dies in bug 566746, so
> I can wait until then to land this. Or I could also kill FormAutoComplete.js
> myself so that Enn doesn't need to deal with it...

Actually, we're not even hitting that code path in FormAutoComplete.js, so removing this doesn't cause any errors.

Comment 3

[:Margaret Leibovic]

+mbrubeck, since metro might have similar dead code. See also bug 861005.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/45a191a4e3fb

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/45a191a4e3fb