838440 - Thumbnails disappear after rotation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Open about:home
2) Rotate to landscape orientation
3) Turn off phone's screen
4) Rotate to vertical orientation
5) Turn screen back on

After these STR, the thumbnails on about:home are all shown as placeholder images instead of the real thumbnails.

Comment 1

[Aaron Train [:aaronmt]]

wfm

Comment 2

[Aaron Train [:aaronmt]]

Oh scratch that; yeah see this.

Comment 3

[Andreea Pod]

The regression window for this issue is:

good build:
2012/11/01

bad build 
2012/11/02

possible push-log:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5bd5bb168eb1&tochange=556b9cfb269f

Comment 4

[Brian Nicholson (:bnicholson)]

Lucas, think this could be a regression from bug 785945?

Comment 5

[Wesley Johnston (:wesj)]

Going to see if the fixes in bug 826639 help with this.

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Patch

Nope. We do get an update call to update the thumbnails when our orientation changes, and we do it, but that all happens while we're in the background invisible. Since there are no views to update (we're hidden), we fetch all the thumbnails and throw them away here:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AboutHomeContent.java#383

Then when about:home is shown and we do have views, we happily create about_home_topsite_items that have the firefox icon as their default background image.

This forces us to update about:home when we resume the activity and fixes the bug. Its easy to take to aurora and/or beta if we want. I tried a few other ways to detect when we come back from a power down, but couldn't find anything.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Lucas - can you get to this review this week?  We're going to build FF20 beta 4 on Tues Mar 12th and would like to get this verified and uplifted to beta prior to that so it can get proper testing on beta with users before shipping.

Comment 8

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e941dae46ba

Comment 9

[Wesley Johnston (:wesj)]

Comment on attachment 719783 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 785945
User impact if declined: If the screen if off when you rotate your phone (in your pocket?), thumbnails can disappear for awhile.
Testing completed (on m-c, etc.): Landed on mc today
Risk to taking this patch (and alternatives if risky): Low risk. Pretty simple change that just refreshes about:home (in Java) any time we're restored from the background. May have a slight performance impact, but we've optimized about:home to refresh quickly, so it should be miniscule. If its not, we've got other problems.
String or UUID changes made by this patch: None.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8e941dae46ba

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 719783 [details] [diff] [review]
Patch

Looks good - please land to branches today in preparation for tomorrow's Beta.

Comment 12

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9c89f0cb66ab
https://hg.mozilla.org/releases/mozilla-aurora/rev/77574e5bb0e9

Comment 13

[Adrian Tamas (:AdrianT)]

Unable to reproduce the issue anymore on Nightly 22.0a1 2013-03-14, Aurora 21.0a2 2013-03-14, Firefox Mobile 20 beta 5 on the Samsung Galaxy Tab 2 7.0 (Android 4.1.1) and LG Nexus 4 (Android 4.2.2). Marking the issue as verified.