Bagheera client failing after JSM merging

RESOLVED FIXED in Firefox 21

Status

RESOLVED FIXED
6 years ago
a month ago

People

(Reporter: gps, Assigned: gps)

Tracking

unspecified
Firefox 21

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Due to bug 838458, when we merged JSMs in bug 836177 we accidentally broke the Bagheera HTTP client. I doubt Nightly has been submitting FHR payloads since Jan 31 because of this. #fail.

Patch forthcoming.
(Assignee)

Comment 1

6 years ago
Created attachment 710488 [details] [diff] [review]
Improve rest.js integration, v1

The main patch is moving the rest.js inclusion. rest.js is now always Cu.imported because it isn't compatible with strict mode. This will regress memory usage slightly until we make rest.js work in strict mode.

The rest of the patch is to make RESTRequest log into BagheeraClient. I've been wanting to do this for a while and this was as good of an excuse as any.
Attachment #710488 - Flags: review?(rnewman)
(Assignee)

Comment 2

6 years ago
Obligatory notice to njn that this may regress heap size by compartment overhead amount until bug 838458 is resolved or until zones lands.
Attachment #710488 - Flags: review?(rnewman) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/1ed20e6b41c2
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla21

Updated

6 years ago
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21

Updated

a month ago
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.