838512 - [Camera] Camera app is restricted to take pictures with 1600 x 1200 resolution and video clip with CIF resolution only

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Leo]

1. Title : Camera app is restricted to take pictures with 1600 x 1200 resolution and video clip with CIF resolution only
2. Precondition : 
3. Tester's Action : Take pictures and shoot video files
4. Detailed Symptom (ENG.) : Camera app is restricted to take pictures with 1600 x 1200 resolution which is less then 2MP and video clip with CIF resolution (352X288) even if sensor is capable of higher resolutions
5. Gaia Source Version : f46757775e07d314913b4a5ae975fa131d1c7c4b
6. Expected : Camera app should support for multiple resolutions for both Still Image capture and video recording
7.Reproducibility: Y
1)Frequency Rate : 100%
8.Comparison Results : 
1)Model Comparing : 
9. Attached files: 
1)Log : 
2)Test Contents : 
3)Video file :

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

This is by design.  The picture-size restriction makes sure that decoded JPEGs don't take up too much memory in the gallery and other apps on unagi.  Similarly, the CIF limit on the video recorder was due to hitting a memory limit on the DSP.

Comment 2

[Leo]

This should not have raised as bug category.

As our target hardware supports higher resolutions, We have modified the camera application to support higher resolutions. 

We have done following changes in gaia\apps\camera\js\camera.js

Line Number:69
// commented existing CIF support
/*
  _previewConfigVideo: {
    profile: 'cif',
    rotation: 0,
    width: 352,
    height: 288
  },
*/
// added VGA video recording support
  _previewConfigVideo: {
    profile: 'vga',
    rotation: 0,
    width: 640,
    height: 480
  },

Line Number 102:
 //MAX_IMAGE_RES: 1600 * 1200, // Just under 2 megapixels // commented
  MAX_IMAGE_RES: 2560 * 1920, // around 5 megapixels

Along with these changes in gaia, we added definition for VGA recording in GonkRecorderProfiles.def file

With these changes Camera is working fine for 5 MegaPixels still capture and VGA video recording.

Please confirm whether modifications in application side are enough.

Also, Let us know if this change in camera app will cause any other side effects.

Comment 3

[Michael Vines [:m1] [:evilmachines]]

IMO, we should fix the camera app in the v1.1 timeframe that it doesn't hard code these values and instead obtains these parameters via a target-specific API.

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

There are a number of camera properties we have hardcoded for v1.  Bug 804359 already exists to expose different video recording profiles; I've created meta bug 844920 and bug 844921 to track image size (and other properties).

Comment 5

[David Flanagan [:djf]]

If you exceed 5 megapixels in the camera app, then the gallery app will need a corresponding change, or it will reject the images as too large.

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

djf, does that mean the gallery, filmstrip, et al can handle up to 5MP images on the 256MB-platform now?

Comment 7

[Mike Habicher [:mikeh] (high bugzilla latency)]

nm, I just saw the information you provided in bug 844921.