Closed Bug 838552 Opened 7 years ago Closed 7 years ago

nsSessionStartup.js' debug code is noisy

Categories

(Firefox :: Session Restore, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 21

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file, 1 obsolete file)

I see 10 messages logged from nsSessionStartup.js in the Error Console at startup with a current nightly. They were added in bug 532150 but don't seem particularly useful.

I think we should either turn off debug calls by default (what the attached patch does) or just remove these debug() calls.
Attachment #710633 - Flags: feedback?(dteller)
Comment on attachment 710633 [details] [diff] [review]
Turn off debug in that file by default

Review of attachment 710633 [details] [diff] [review]:
-----------------------------------------------------------------

My bad, I assumed that |debug| was somehow deactivated. Let's just get rid of these |debug(...)| calls.
Attachment #710633 - Flags: feedback?(dteller)
Awesome, I always wanted to fix that. Thank you Florian for tackling this.
Attached patch Patch v2Splinter Review
Remove leftover debug statements.

I tried to keep the debug() calls that are for actual error cases. By quickly looking at the code I couldn't decide if debug("onSessionFileRead: Initialization is already complete"); was an error case or an expected situation.
Assignee: nobody → florian
Attachment #710633 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #710808 - Flags: review?(dteller)
Comment on attachment 710808 [details] [diff] [review]
Patch v2

Review of attachment 710808 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks for the patch
Attachment #710808 - Flags: review?(dteller) → review+
Thanks for the patch, Florian! Can you please prepare it for checkin?
https://hg.mozilla.org/integration/mozilla-inbound/rev/b06c27ea62a8

(In reply to Tim Taubert [:ttaubert] from comment #5)
> Thanks for the patch, Florian! Can you please prepare it for checkin?

No problem. Pushing to mozilla-inbound was easier than attaching another patch here ;).
https://hg.mozilla.org/mozilla-central/rev/b06c27ea62a8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
You need to log in before you can comment on or make changes to this bug.