838552 - nsSessionStartup.js' debug code is noisy

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Florian Quèze [:florian]]

Attachment: Turn off debug in that file by default

I see 10 messages logged from nsSessionStartup.js in the Error Console at startup with a current nightly. They were added in bug 532150 but don't seem particularly useful.

I think we should either turn off debug calls by default (what the attached patch does) or just remove these debug() calls.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 710633 [details] [diff] [review]
Turn off debug in that file by default

Review of attachment 710633 [details] [diff] [review]:
-----------------------------------------------------------------

My bad, I assumed that |debug| was somehow deactivated. Let's just get rid of these |debug(...)| calls.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Awesome, I always wanted to fix that. Thank you Florian for tackling this.

Comment 3

[Florian Quèze [:florian]]

Attachment: Patch v2

Remove leftover debug statements.

I tried to keep the debug() calls that are for actual error cases. By quickly looking at the code I couldn't decide if debug("onSessionFileRead: Initialization is already complete"); was an error case or an expected situation.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 710808 [details] [diff] [review]
Patch v2

Review of attachment 710808 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks for the patch

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Thanks for the patch, Florian! Can you please prepare it for checkin?

Comment 6

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b06c27ea62a8

(In reply to Tim Taubert [:ttaubert] from comment #5)
> Thanks for the patch, Florian! Can you please prepare it for checkin?

No problem. Pushing to mozilla-inbound was easier than attaching another patch here ;).

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b06c27ea62a8