Kill object equality hook

RESOLVED FIXED in mozilla21

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

Trunk
mozilla21
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Because of CPG we can remove at least XPConnect hooks, see bug 812669. We also have some usage of this in ObjectWrapperParent ("CPOWs"), but I am not sure about those. 
I pushed a patch to try that removes it as well, we will see how this goes.
https://tbpl.mozilla.org/?tree=Try&rev=730dc963803b
(Assignee)

Updated

5 years ago
Assignee: general → evilpies
(Assignee)

Updated

5 years ago
Blocks: 839115
(Assignee)

Comment 1

5 years ago
Created attachment 711882 [details] [diff] [review]
v1
Attachment #711882 - Flags: review?(jorendorff)
Comment on attachment 711882 [details] [diff] [review]
v1

Review of attachment 711882 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. And my fingers are crossed hoping it sticks.

::: js/src/ion/MIR.cpp
@@ +1226,5 @@
>      {
>          return false;
>      }
>  
> +    // Objects emulate undefined are not supported.

"Objects that emulate"

::: js/src/jsinfer.h
@@ +401,3 @@
>  
>      /* Flags which indicate dynamic properties of represented objects. */
>      OBJECT_FLAG_DYNAMIC_MASK          = 0x00ff0000,

I guess this could go from ff to 7f.
Attachment #711882 - Flags: review?(jorendorff) → review+

Comment 3

5 years ago
Comment on attachment 711882 [details] [diff] [review]
v1

Review of attachment 711882 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/methodjit/FastOps.cpp
@@ +421,3 @@
>      }
>  
>      return Compile_Skipped;

This is dead code now, as both arms end in a return.  (Which means one or the other should be if'd, and the other bit should be unindented, really.)
(Assignee)

Comment 4

5 years ago
Thank you guys. I also removed some unnecessary type query in FastOps.cpp. (Thank you compiler :)
https://hg.mozilla.org/integration/mozilla-inbound/rev/d91d6e2bc258
(Assignee)

Comment 5

5 years ago
I dropped the changes to XPC before check-in.
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b5dc3b3b21c

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d91d6e2bc258
https://hg.mozilla.org/mozilla-central/rev/6b5dc3b3b21c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.