838572 - consider pushing l10n later in the startup cycle to speed up HTML drawing

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Since we're precompiling l10n now, it seems to be potentially beneficial to minimize the startup competition within the app by moving l10n post onload.

This also gets us closer to the ideal of apps splitting JS initialization into two phases: one that happens onload and one that happens when 'localized' is fired plus reward l10n in HTML.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: POC

POC that moves l10n.js to defer (~50ms win) and delays loading l10n post onload.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

           || master      ||  patch      ||  delta
===========||=============||=============||=========
Template   ||   530 (10)  ||   532 (10)  ||  +2
Settings   ||  2002 (51)  ||  1704 (61)  ||  -298
SMS        ||  1384 (42)  ||  1211 (17)  ||  -173
Calendar   ||  1909 (26)  ||  1876 (40)  ||  -33
Email      ||  3384 (20)  ||  3329 (25)  ||  -55
Contacts   ||  2733 (19)  ||  1895 (41)  ||  -838
Browser    ||  1090 (40)  ||  1076 (20)  ||  -14
Dialer     ||  1361 (51)  ||  1333 (14)  ||  -28

It's not as rosy as it seems since we're actually delaying firing "localized" event and all strings that are added to the screen from JS will show up later, but it does give some nice wins for some apps (in particular, Contacts, Settings and SMS) so it may be worth investigating.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

I can still reproduce the same win with the same apps on todays nightly:

           || master      ||  patch      ||  delta
===========||=============||=============||=========
Template   ||   401 (26)  ||   412  (6)  ||  +11
Settings   ||  1747 (92)  ||  1485  (6)  ||  -262
SMS        ||  1229 (86)  ||  1059 (37)  ||  -170
Calendar   ||  1824 (25)  ||  1809 (12)  ||  -15
Email      ||  2797 (84)  ||  2778 (74)  ||  -19
Contacts   ||   906  (9)  ||   888 (20)  ||  -18
Browser    ||   972 (39)  ||   978 (32)  ||  +6
Dialer     ||  1065 (22)  ||  1035 (15)  ||  -30

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

today's build

           || master      ||  patch      ||  delta
===========||=============||=============||=========
Template   ||   346       ||   346       ||  0
Settings   ||  1086       ||  1013       ||  -73
SMS        ||  1045       ||   982       ||  -63
Calendar   ||  1291       ||  1308       ||  +17
Email      ||  2620       ||  2557       ||  -63
Contacts   ||   847       ||   833       ||  -14
Browser    ||  1084       ||  1049       ||  -35
Dialer     ||  1016       ||   996       ||  -20

it still seems to be beneficial, but not by a high margin anymore

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch

updated patch.

Chris: is it worth pursuing this direction or should we close this bug?

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Looks like the data says that this isn't worth investing in right now.

Comment 7

[Florian Bender]

Should this bug be closed, then?

Comment 8

[Dietrich Ayala (:dietrich)]

per above comments