838583 - Favicons are tiny in Awesomebar history tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: screenshot on Nexus 4

While they seem to be the correct size in Top Sites and Bookmarks, they are way too small in the History tab.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Scale favicons in the history tab

Since we moved the scaling logic outside of AwesomeBarTab, we need to scale it here too.

Comment 2

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1aa612b762f3

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 711683 [details] [diff] [review]
Scale favicons in the history tab

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 819973
User impact if declined: small favicons in history tab
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): very low risk
String or UUID changes made by this patch: none

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1aa612b762f3

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 711683 [details] [diff] [review]
Scale favicons in the history tab

Given the risk here is limited to HistoryTab, and this is known working code for favicons, this is manageable risk for Beta 6. Adding qawanted/verifyme to make sure we didn't regress anything.

Comment 6

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/releases/mozilla-beta/rev/04cddbb44d21

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b377d89834cb

Comment 8

[Andreea Pod]

Verified fixed on:
-build: Firefox for Android 20.0a2 (2013-02-11), Firefox for Android 21.0a1 (2013-02-11)
-device: Samsung Galaxy Nexus 
-OS: Android 4.1.2