355 bytes, text/html
I have just realized that the USSD/MMI tests are failing, more concretely from [communications] Call forwarding request via MMI. Active voice [communications] Check call forwarding rules ‣ Error: TypeError: navigator.mozL10n.keys is not a function (http://communications.gaiamobile.org:8080/dialer/test/unit/ussd_test.js?time=1360163574152:196) at onerror (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959) on. In fact, it is kind of weird since the suite "Call forwarding request via MMI. Active voice" ( https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/test/unit/ussd_test.js#L188 ) uses variables which are not declared or in scope.
Assignee: nobody → ferjmoreno
I assigned the bug to you, Fernando, just because git blames you... :-p We can discuss about what should be tested there and I could take care of fixing it ;-)
(In reply to gtorodelvalle from comment #1) > I assigned the bug to you, Fernando, just because git blames you... git blames me for writing the tests, not for breaking them. This used to work. I'll take a look at them as soon as I can.
You are absolutely right!!! :-D My bad ;-) Filling a feature request to Github to add "git test-breaker-blame" :-p Thanks!
Hey guys, I'm disabling these tests as part of https://bugzilla.mozilla.org/show_bug.cgi?id=838993 . My intention is to begin fixing and re-enabling them after that. Would you mind updating this bug to block 838993 ?
Sure! Thanks Mike!
Created attachment 713948 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8107 Pointer to Github pull-request
Attachment #713948 - Flags: review?(francisco.jordano)
Comment on attachment 713948 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8107 Thanks for the work Fernando!
Attachment #713948 - Flags: review?(francisco.jordano) → review+
Evolving it to RESOLVED-FIXED since the pull request already merged ;-) Thanks!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
v1-train: 898646aa9cfb3307c964c9e028acd683b601bd27 v1.0.1: 5e064fb4cc31efc69bf173d50e4b8bdca9247598
status-b2g18: --- → fixed
status-b2g18-v1.0.1: --- → fixed
Can you please provide steps to verify this fix - as we will blackbox test from the UI?
You can run the communications/dialer/test/unit/ussd_test.js tests using the test-agent as described in https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Platform/Testing/Gaia_unit_tests
No need to create a TC in Moztrap for this issue.
Cannot verify, do not have tools to test this issue.
You need to log in before you can comment on or make changes to this bug.