838652 - Use res-auto namespace alias instead of autotools substitutions for package name

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

We use autotools substitutions on our layout files to use the app's package name (@ANDROID_PACKAGE_NAME@) but we should be using Android's proper alias for package name: http://schemas.android.com/apk/res-auto

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Use res-auto namespace alias instead of preprocessing files

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 724934 [details] [diff] [review]
Use res-auto namespace alias instead of preprocessing files

Looks good to me. Make sure you do a Try server run first. Also, passing to Sriram for his OK too.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 724934 [details] [diff] [review]
Use res-auto namespace alias instead of preprocessing files

Review of attachment 724934 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. As per http://android-developers.blogspot.com/2012/03/updated-sdk-tools-and-adt-revision-17.html, res-auto was added/started supporting only in r17 of ADT. (Even that is one year old! :O :O)

Comment 4

[Sriram Ramasubramanian [:sriram]]

Adding bnicholson to let him know that we don't need any pre-processing of XML anymore.

Comment 5

[Lucas Rocha (:lucasr)]

Sent to try: https://tbpl.mozilla.org/?tree=Try&rev=b1753c9d7de1

Comment 6

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/e9843158cc6a

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e9843158cc6a

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

This patch moved too many files out of the preprocessing chain. Most importantly,  browser_app_menu.xml files still look for MOZ_PROFILING to show/hide the "Toggle Profile" menu it. This menu is now visible all the time.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Simple check for affected files:
http://mxr.mozilla.org/mozilla-central/search?string=ifdef&find=mobile%2Fandroid%2Fbase%2Fresources&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central