Use res-auto namespace alias instead of autotools substitutions for package name

RESOLVED FIXED in Firefox 22

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 22
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We use autotools substitutions on our layout files to use the app's package name (@ANDROID_PACKAGE_NAME@) but we should be using Android's proper alias for package name: http://schemas.android.com/apk/res-auto
(Assignee)

Comment 1

5 years ago
Created attachment 724934 [details] [diff] [review]
Use res-auto namespace alias instead of preprocessing files
Attachment #724934 - Flags: review?(mark.finkle)
Comment on attachment 724934 [details] [diff] [review]
Use res-auto namespace alias instead of preprocessing files

Looks good to me. Make sure you do a Try server run first. Also, passing to Sriram for his OK too.
Attachment #724934 - Flags: review?(sriram)
Attachment #724934 - Flags: review?(mark.finkle)
Attachment #724934 - Flags: review+
Comment on attachment 724934 [details] [diff] [review]
Use res-auto namespace alias instead of preprocessing files

Review of attachment 724934 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. As per http://android-developers.blogspot.com/2012/03/updated-sdk-tools-and-adt-revision-17.html, res-auto was added/started supporting only in r17 of ADT. (Even that is one year old! :O :O)
Attachment #724934 - Flags: review?(sriram) → review+
Adding bnicholson to let him know that we don't need any pre-processing of XML anymore.
https://hg.mozilla.org/mozilla-central/rev/e9843158cc6a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
This patch moved too many files out of the preprocessing chain. Most importantly,  browser_app_menu.xml files still look for MOZ_PROFILING to show/hide the "Toggle Profile" menu it. This menu is now visible all the time.

Updated

5 years ago
Depends on: 851920
You need to log in before you can comment on or make changes to this bug.