Closed
Bug 838652
Opened 10 years ago
Closed 10 years ago
Use res-auto namespace alias instead of autotools substitutions for package name
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(1 file)
48.60 KB,
patch
|
mfinkle
:
review+
sriram
:
review+
|
Details | Diff | Splinter Review |
We use autotools substitutions on our layout files to use the app's package name (@ANDROID_PACKAGE_NAME@) but we should be using Android's proper alias for package name: http://schemas.android.com/apk/res-auto
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #724934 -
Flags: review?(mark.finkle)
Comment 2•10 years ago
|
||
Comment on attachment 724934 [details] [diff] [review] Use res-auto namespace alias instead of preprocessing files Looks good to me. Make sure you do a Try server run first. Also, passing to Sriram for his OK too.
Attachment #724934 -
Flags: review?(sriram)
Attachment #724934 -
Flags: review?(mark.finkle)
Attachment #724934 -
Flags: review+
Comment 3•10 years ago
|
||
Comment on attachment 724934 [details] [diff] [review] Use res-auto namespace alias instead of preprocessing files Review of attachment 724934 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me. As per http://android-developers.blogspot.com/2012/03/updated-sdk-tools-and-adt-revision-17.html, res-auto was added/started supporting only in r17 of ADT. (Even that is one year old! :O :O)
Attachment #724934 -
Flags: review?(sriram) → review+
Comment 4•10 years ago
|
||
Adding bnicholson to let him know that we don't need any pre-processing of XML anymore.
Assignee | ||
Comment 5•10 years ago
|
||
Sent to try: https://tbpl.mozilla.org/?tree=Try&rev=b1753c9d7de1
Assignee | ||
Comment 6•10 years ago
|
||
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/e9843158cc6a
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e9843158cc6a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Comment 8•10 years ago
|
||
This patch moved too many files out of the preprocessing chain. Most importantly, browser_app_menu.xml files still look for MOZ_PROFILING to show/hide the "Toggle Profile" menu it. This menu is now visible all the time.
Comment 9•10 years ago
|
||
Simple check for affected files: http://mxr.mozilla.org/mozilla-central/search?string=ifdef&find=mobile%2Fandroid%2Fbase%2Fresources&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•