Closed Bug 838721 Opened 9 years ago Closed 9 years ago
DOMDevice Storage should have ns DOMEvent Target Helper as its first base class
It inherits from nsDOMEventTargetHelper, but not as the first class. The DOM binding code relies on it. For now we're safe because it uses an XPConnect binding *and* it forwards QI for the canonical nsISupports to nsDOMEventTargetHelper. It also uses NS_DECL_ISUPPORTS as opposed to NS_DECL_ISUPPORTS_INHERITED, so it has an unused additional refcount. We got lucky because it forwards AddRef and Release to nsDOMEventTargetHelper, so the CC never runs into the extra refcount. Bug 687332 gutted the traverse and unlink functions, it should have also removed the participant etc.
Attachment #710809 - Flags: review?(bugs) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.