nsDOMDeviceStorage should have nsDOMEventTargetHelper as its first base class

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
7 years ago
5 months ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla21
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It inherits from nsDOMEventTargetHelper, but not as the first class. The DOM binding code relies on it. For now we're safe because it uses an XPConnect binding *and* it forwards QI for the canonical nsISupports to nsDOMEventTargetHelper.

It also uses NS_DECL_ISUPPORTS as opposed to  NS_DECL_ISUPPORTS_INHERITED, so it has an unused additional refcount. We got lucky because it forwards AddRef and Release to nsDOMEventTargetHelper, so the CC never runs into the extra refcount.

Bug 687332 gutted the traverse and unlink functions, it should have also removed the participant etc.
Posted patch v1Splinter Review
Attachment #710809 - Flags: review?(bugs)
Attachment #710809 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/0af7f130555a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.