Closed
Bug 838721
Opened 12 years ago
Closed 12 years ago
nsDOMDeviceStorage should have nsDOMEventTargetHelper as its first base class
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: peterv, Assigned: peterv)
References
Details
Attachments
(1 file)
|
2.18 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
It inherits from nsDOMEventTargetHelper, but not as the first class. The DOM binding code relies on it. For now we're safe because it uses an XPConnect binding *and* it forwards QI for the canonical nsISupports to nsDOMEventTargetHelper.
It also uses NS_DECL_ISUPPORTS as opposed to NS_DECL_ISUPPORTS_INHERITED, so it has an unused additional refcount. We got lucky because it forwards AddRef and Release to nsDOMEventTargetHelper, so the CC never runs into the extra refcount.
Bug 687332 gutted the traverse and unlink functions, it should have also removed the participant etc.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #710809 -
Flags: review?(bugs)
|
||
Updated•12 years ago
|
Attachment #710809 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•