838757 - Add a transition to the EV+SSL identity icon label

Status: RESOLVED INACTIVE

(Firefox :: Address Bar, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

The attached patch adds a transition for the identity-icon-labels when a webpage is loaded in the current tab and there is an EV SSL certificate provided by the website.

The animation is not supposed to occur when the user is switching tabs or if the user cancels their location bar typing.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 710847 [details] [diff] [review]
Patch

>@@ -4452,16 +4452,25 @@ var XULBrowserWindow = {
>       locationObj.host = location.host;
>       locationObj.hostname = location.hostname;
>       locationObj.port = location.port;
>     } catch (ex) {
>       // Can sometimes throw if the URL being visited has no host/hostname,
>       // e.g. about:blank. The _state for these pages means we won't need these
>       // properties anyways, though.
>     }
>+
>+    var identityIconLabels = document.getElementById("identity-icon-labels");
>+    if (identityIconLabels) {
>+      if (aRequest)
>+        identityIconLabels.removeAttribute("immediate");
>+      else
>+        identityIconLabels.setAttribute("immediate", "true");
>+    }
>+
>     gIdentityHandler.checkIdentity(this._state, locationObj);
>   },

How about "skipanimation" or "dontanimate" rather than "immediate"? In any case, this code would need some documentation. The UI is updated in setIdentityMessages, which is rather far away from this code. This is somewhat messy.

The transition is not at all smooth for me. Looks like a get only one or two intermediate frames, probably because the page is loading in parallel (tested with paypal.com).

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Unassigning as I haven't been working on this and I don't want to hold people up.

Comment 3

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.