Remove deprecated nsILivemarkService interface

RESOLVED FIXED in mozilla22

Status

()

Toolkit
Places
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

({addon-compat, dev-doc-needed})

Trunk
mozilla22
addon-compat, dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
let's do this.
(Assignee)

Updated

4 years ago
Summary: Remove deprecated Livemarks interface → Remove deprecated nsILivemarkService interface
(Assignee)

Updated

4 years ago
Blocks: 834493
(Assignee)

Updated

4 years ago
Keywords: addon-compat, dev-doc-needed
(Assignee)

Comment 1

4 years ago
and also
PlacesUtils.itemIsLivemark
PlacesUtils.nodeIsLivemarkContainer
PlacesUtils.nodeIsLivemarkItem
(Assignee)

Comment 2

4 years ago
Created attachment 710956 [details] [diff] [review]
patch v1.0
(Assignee)

Comment 3

4 years ago
Comment on attachment 710956 [details] [diff] [review]
patch v1.0

Ok, I think I got all of the pieces, will send to Try before landing, just in case.
Attachment #710956 - Flags: review?(mano)
(Assignee)

Comment 4

4 years ago
Created attachment 711118 [details] [diff] [review]
patch v1.1

Forgot to update PlacesUtils.livemarks
Attachment #710956 - Attachment is obsolete: true
Attachment #710956 - Flags: review?(mano)
Attachment #711118 - Flags: review?(mano)
Attachment #711118 - Flags: review?(mano) → review+
(Assignee)

Comment 5

4 years ago
Comment on attachment 711118 [details] [diff] [review]
patch v1.1

not a lot to say, just nsILivemarkService interface going away
Attachment #711118 - Flags: superreview?(gavin.sharp)
Have we shipped deprecation warnings for this interface? I see a lot of users on AMO (both directly and via PlacesUtils).
(Assignee)

Comment 7

4 years ago
yes, all methods of the interface were sending messages to the console about deprecation, plus the interface itself said it was deprecated and to use the async version.
I honestly don't think we are really lucky with add-ons conversion to new APIs until they actually hit the API removal (for various reasons, even valid, like the fact most are volunteer with few time).
Attachment #711118 - Flags: superreview?(gavin.sharp) → superreview+
(Assignee)

Comment 8

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/be1a404904f3
Target Milestone: --- → mozilla22

Comment 9

4 years ago
https://hg.mozilla.org/mozilla-central/rev/be1a404904f3
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Depends on: 846549
You need to log in before you can comment on or make changes to this bug.