Last Comment Bug 838798 - Remove deprecated nsILivemarkService interface
: Remove deprecated nsILivemarkService interface
: addon-compat, dev-doc-needed
Product: Toolkit
Classification: Components
Component: Places (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla22
Assigned To: Marco Bonardo [::mak]
: Marco Bonardo [::mak]
Depends on: 846549
Blocks: 834457 834493
  Show dependency treegraph
Reported: 2013-02-06 12:58 PST by Marco Bonardo [::mak]
Modified: 2013-03-23 03:58 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch v1.0 (24.10 KB, patch)
2013-02-06 13:51 PST, Marco Bonardo [::mak]
no flags Details | Diff | Splinter Review
patch v1.1 (25.01 KB, patch)
2013-02-06 17:42 PST, Marco Bonardo [::mak]
asaf: review+ superreview+
Details | Diff | Splinter Review

Description User image Marco Bonardo [::mak] 2013-02-06 12:58:07 PST
let's do this.
Comment 1 User image Marco Bonardo [::mak] 2013-02-06 13:08:28 PST
and also
Comment 2 User image Marco Bonardo [::mak] 2013-02-06 13:51:24 PST
Created attachment 710956 [details] [diff] [review]
patch v1.0
Comment 3 User image Marco Bonardo [::mak] 2013-02-06 14:19:17 PST
Comment on attachment 710956 [details] [diff] [review]
patch v1.0

Ok, I think I got all of the pieces, will send to Try before landing, just in case.
Comment 4 User image Marco Bonardo [::mak] 2013-02-06 17:42:59 PST
Created attachment 711118 [details] [diff] [review]
patch v1.1

Forgot to update PlacesUtils.livemarks
Comment 5 User image Marco Bonardo [::mak] 2013-02-07 04:59:04 PST
Comment on attachment 711118 [details] [diff] [review]
patch v1.1

not a lot to say, just nsILivemarkService interface going away
Comment 6 User image :Gavin Sharp [email:] 2013-02-07 08:40:58 PST
Have we shipped deprecation warnings for this interface? I see a lot of users on AMO (both directly and via PlacesUtils).
Comment 7 User image Marco Bonardo [::mak] 2013-02-07 12:17:45 PST
yes, all methods of the interface were sending messages to the console about deprecation, plus the interface itself said it was deprecated and to use the async version.
I honestly don't think we are really lucky with add-ons conversion to new APIs until they actually hit the API removal (for various reasons, even valid, like the fact most are volunteer with few time).
Comment 9 User image Gregory Szorc [:gps] (away until 2017-03-20) 2013-02-28 10:03:27 PST

Note You need to log in before you can comment on or make changes to this bug.