838798 - Remove deprecated nsILivemarkService interface

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

let's do this.

Comment 1

[Marco Bonardo [:mak]]

and also
PlacesUtils.itemIsLivemark
PlacesUtils.nodeIsLivemarkContainer
PlacesUtils.nodeIsLivemarkItem

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 710956 [details] [diff] [review]
patch v1.0

Ok, I think I got all of the pieces, will send to Try before landing, just in case.

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Forgot to update PlacesUtils.livemarks

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 711118 [details] [diff] [review]
patch v1.1

not a lot to say, just nsILivemarkService interface going away

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Have we shipped deprecation warnings for this interface? I see a lot of users on AMO (both directly and via PlacesUtils).

Comment 7

[Marco Bonardo [:mak]]

yes, all methods of the interface were sending messages to the console about deprecation, plus the interface itself said it was deprecated and to use the async version.
I honestly don't think we are really lucky with add-ons conversion to new APIs until they actually hit the API removal (for various reasons, even valid, like the fact most are volunteer with few time).

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be1a404904f3

Comment 9

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/be1a404904f3