Closed
Bug 838798
Opened 11 years ago
Closed 11 years ago
Remove deprecated nsILivemarkService interface
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: addon-compat, dev-doc-needed)
Attachments
(1 file, 1 obsolete file)
25.01 KB,
patch
|
asaf
:
review+
Gavin
:
superreview+
|
Details | Diff | Splinter Review |
let's do this.
Assignee | ||
Updated•11 years ago
|
Summary: Remove deprecated Livemarks interface → Remove deprecated nsILivemarkService interface
Assignee | ||
Updated•11 years ago
|
Keywords: addon-compat,
dev-doc-needed
Assignee | ||
Comment 1•11 years ago
|
||
and also PlacesUtils.itemIsLivemark PlacesUtils.nodeIsLivemarkContainer PlacesUtils.nodeIsLivemarkItem
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 710956 [details] [diff] [review] patch v1.0 Ok, I think I got all of the pieces, will send to Try before landing, just in case.
Attachment #710956 -
Flags: review?(mano)
Assignee | ||
Comment 4•11 years ago
|
||
Forgot to update PlacesUtils.livemarks
Attachment #710956 -
Attachment is obsolete: true
Attachment #710956 -
Flags: review?(mano)
Attachment #711118 -
Flags: review?(mano)
Updated•11 years ago
|
Attachment #711118 -
Flags: review?(mano) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 711118 [details] [diff] [review] patch v1.1 not a lot to say, just nsILivemarkService interface going away
Attachment #711118 -
Flags: superreview?(gavin.sharp)
Comment 6•11 years ago
|
||
Have we shipped deprecation warnings for this interface? I see a lot of users on AMO (both directly and via PlacesUtils).
Assignee | ||
Comment 7•11 years ago
|
||
yes, all methods of the interface were sending messages to the console about deprecation, plus the interface itself said it was deprecated and to use the async version. I honestly don't think we are really lucky with add-ons conversion to new APIs until they actually hit the API removal (for various reasons, even valid, like the fact most are volunteer with few time).
Updated•11 years ago
|
Attachment #711118 -
Flags: superreview?(gavin.sharp) → superreview+
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/be1a404904f3
Target Milestone: --- → mozilla22
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/be1a404904f3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•