Closed Bug 838798 Opened 7 years ago Closed 7 years ago

Remove deprecated nsILivemarkService interface

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: addon-compat, dev-doc-needed)

Attachments

(1 file, 1 obsolete file)

let's do this.
Summary: Remove deprecated Livemarks interface → Remove deprecated nsILivemarkService interface
Blocks: 834493
and also
PlacesUtils.itemIsLivemark
PlacesUtils.nodeIsLivemarkContainer
PlacesUtils.nodeIsLivemarkItem
Attached patch patch v1.0 (obsolete) — Splinter Review
Comment on attachment 710956 [details] [diff] [review]
patch v1.0

Ok, I think I got all of the pieces, will send to Try before landing, just in case.
Attachment #710956 - Flags: review?(mano)
Attached patch patch v1.1Splinter Review
Forgot to update PlacesUtils.livemarks
Attachment #710956 - Attachment is obsolete: true
Attachment #710956 - Flags: review?(mano)
Attachment #711118 - Flags: review?(mano)
Comment on attachment 711118 [details] [diff] [review]
patch v1.1

not a lot to say, just nsILivemarkService interface going away
Attachment #711118 - Flags: superreview?(gavin.sharp)
Have we shipped deprecation warnings for this interface? I see a lot of users on AMO (both directly and via PlacesUtils).
yes, all methods of the interface were sending messages to the console about deprecation, plus the interface itself said it was deprecated and to use the async version.
I honestly don't think we are really lucky with add-ons conversion to new APIs until they actually hit the API removal (for various reasons, even valid, like the fact most are volunteer with few time).
Attachment #711118 - Flags: superreview?(gavin.sharp) → superreview+
https://hg.mozilla.org/mozilla-central/rev/be1a404904f3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.