838886 - Limit gradient patterns cache memory usage

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[Avi Halachmi (:avih)]

Gradient pattern cache items could use a lot of memory per item (see bug 837542 for several MB of cached items), especially when using D2D. While less cache misses due to better cache keys would improve the overall cache memory usage (bug 838758), we might still want to impose some limit on this cache, as it can quickly grow quite large.

Comment 1

[Avi Halachmi (:avih)]

Correction: see bug 837542 for several hundreds MB of cached items.

Comment 2

[Bas Schouten (:bas.schouten)]

So I think using immense amounts of memory is usually due to drivers doing odd things and using much more memory than expected. In general a reasonable limit here is probably something like 1000 patterns which should amount to 16MB.

Comment 3

[Nicholas Nethercote [inactive]]

Removed the MemShrink tag because we have a tag on 837542.

Comment 4

[Fernando Hartmann]

(In reply to Nicholas Nethercote [:njn] from comment #3)
> Removed the MemShrink tag because we have a tag on 837542.

May be the MemShrink tag should be inserted again here, because 837542 is replaced by this bug.

Comment 5

[Gregory Pappas [:gregp]]

So, there's this bug and also bug 848742 (and maybe a few more pertaining to gradient memory usage). Is it still a concern? My understanding is that WebRender has cached render tasks for gradients, so I didn't want to close all of these without asking first.

Thanks!

Comment 6

[Nicolas Silva [:nical]]

Things are different enough that we should close this now and open new bugs if need be.