838895 - [maps] [Inari] Cannot switch from Map view to any other view like Satellite, Public transport, etc

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: General, defect)

Description

[Parul Mathur]

Attachment: Settings menu on the Map app for switching to another view

Test Environment:
Device: Inari phone #16174
Build Identifier: 20130207023449
Update channel: nightly
Git commit info: 2013-02-06 14:30:07 
Gaia Version: d23401f1c1ee2a
OS version: 1.0.1.0

Steps to reproduce:
1. Launch the Maps app.
2. Turn on geo-location.
3. Tap on the bottom right button to get the settings menu.
4. Attempt to select another view like Satellite, Public transport, Live traffic, etc.

Actual results:
Unable to switch from the default Map view to  another view like Satellite, Public transport, Live traffic, etc.

Expected results:
Should be able to switch from the default Map view to  another view like Satellite, Public transport, Live traffic, and Community.

Comment 1

[Marcia Knous [:marcia]]

This works on the unagi device using the latest nightly build, but still doesn't work using:

Gaia   d23401f1c1ee2a46185cbdd460c360710f20a2ed
BuildID 20130207085158

Comment 2

[Michael Wu [:mwu]]

Attachment: Workaround - filter touch events

This mostly fixes the issue on the Inari device. I think the maps app has a bug, but this will make things work till we find a better solution.

Comment 3

[Marcia Knous [:marcia]]

Using

Gaia   eec503b364ecb17200cf87487be9f0d96b6fcbe8
BuildID 20130208144804
Version 18.0

This seems to work okay in this build.

Comment 4

[AndyT]

We can also report that it works fine on Unagi FW 20120207 (Maps app did not change anything here)

Comment 5

[Michael Wu [:mwu]]

The problem is that the particular touchscreen on this device behaves differently than all other devices we've tested on so far.

On most device you would get something like this for a tap:

Touch down 100 x 100
Touch up   100 x 100

On the device we have, a typical tap looks like this:

Touch down 100 x 100
Touch move 100 x 101
Touch up   100 x 101

Note how we get an additional event and location has shifted very slightly. Most pages behave fine with this stream of events - our click detection code will accept anything as long as it doesn't exceed a certain threshold. However, this doesn't work on the radio buttons for the different layers in the maps app.

Is it possible that the maps app is calling preventDefault on the touch move event? This prevents gecko from generating a click event.

The workaround patch I posted here just filters out that touch move event if it's only 1 pixel away from touch down.

Comment 6

[AndyT]

We'd need to get a copy of this device to properly test. I will contact Thomas Elin to get one. We are definitely calling preventDefault in certain cases. We removed those calls from all clicks in scrolling areas, but not in simple buttons.

Btw: it cannot be that you prevent apps from using preventDefault. There are some good use cases for this feature and it will limit the way that we build our user interface.

Comment 7

[AndyT]

When will this patch land in the stable build?

Comment 8

[AndyT]

When will this patch land in the stable build?

Comment 9

[Michael Wu [:mwu]]

I'm not currently planning to land this patch - it's a workaround we're going to use on this device for now. Maybe we can get the touchscreen driver to do better filtering.

BTW our code also calls preventDefault on touchmove, but only if the move exceeds a certain threshold. This lets more jittery touchscreens or fingers tap on things.

Comment 10

[AndyT]

So when can we test that this workaround is working for the Maps app on Unari?

Comment 11

[Andreas Gal :gal]

Comment on attachment 711904 [details] [diff] [review]
Workaround - filter touch events

A creative and really gross hack. This doesn't hurt other devices, so we can as well land it with a big fat explanation. I expect that at least that touch vendor will keep sending us broken code in the future, so its probably safer to deal with it here.

Comment 12

[Pawel Wojciechowski]

Can we close this issue?

Comment 13

[Jason Smith [:jsmith]]

(In reply to pawel.wojciechowski from comment #12)
> Can we close this issue?

I don't think the patch landed here to allow us to close this.

Comment 14

[Jason Smith [:jsmith]]

needs to be retested per the fix in bug 869356

Comment 15

[Mila Davydova]

This issue no longer reproduces on Inari v1.0.1
Build ID: 20130528070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9aaf82b015cf
Gaia: 50abeb2c622bfe48803b732776daecb2fa34e575
Version 18.0

User is able to switch from the default Map view to Satellite, Public transport, Live traffic and Community view.